Skip to content

audacity: respect the Darwin deployment target - #560876

Closed
johnrichardrinehart wants to merge 1 commit into
NixOS:masterfrom
johnrichardrinehart:audacity-3-darwin-deployment-target
Closed

johnrichardrinehart wants to merge 1 commit into
NixOS:masterfrom
johnrichardrinehart:audacity-3-darwin-deployment-target

Conversation

@johnrichardrinehart

@johnrichardrinehart johnrichardrinehart commented Sep 7, 2026 •

Copy link
Copy Markdown
Contributor

Description of changes

Apply audacity/audacity#12022 using commit-pinned fetchpatch2 and pass stdenv.hostPlatform.darwinMinVersion explicitly. This keeps CMake and explicit linker minimums consistent with the compiler wrapper. Current nixpkgs defaults to macOS 14.0; overrides remain respected.

The upstream fix synchronizes normal and cached CMake targets and enforces the Apple Silicon minimum of macOS 11.0. The separate upstream SDK-version rendering workaround is preserved.

This remains separate from the Audacity 4 upgrade in #559623.

Verification

Fetched patch applied to Audacity 3.7.9. Actual package flags selected 14.0 by default and 15.0 with an override for both architecture branches. Default/environment/explicit precedence and ARM64 minimum checks passed, including normal/cache consistency. Package evaluation and formatting passed. Native Darwin build/runtime verification remains outstanding.

Automation disclosure

OpenAI Codex / GPT-6-astra assisted with investigation, implementation, upstream submission, validation, and PR text. Draft pending native verification and human review.

@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. llm-assisted Contributions that include code generation with LLMs labels Sep 7, 2026
Fetch the upstream deployment override fix and pass stdenv.hostPlatform.darwinMinVersion explicitly, keeping CMake and linker minimums consistent with the compiler wrapper. Preserve the separate upstream SDK-version rendering workaround.

Upstream: audacity/audacity#12022

Assisted-by: OpenAI Codex / GPT-6-astra
@johnrichardrinehart
johnrichardrinehart force-pushed the audacity-3-darwin-deployment-target branch from 3d7e547 to ce5befe Compare September 7, 2026 13:23
@ofborg ofborg Bot added the 6.topic: darwin Running or building packages on Darwin label Sep 7, 2026
@nixpkgs-ci nixpkgs-ci Bot added 2.status: merge conflict This PR has merge conflicts with the target branch 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. labels Sep 7, 2026
@RossSmyth

Copy link
Copy Markdown
Contributor

Why did you modify the PR template? Please do not to that.

Please both read all the listed guidelines in the template (they are there for a reason!), and reapply the template. Re-open the PR when you have done so, and a reviewer will get to your PR when they are able to. Thank you.

@RossSmyth RossSmyth closed this Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. llm-assisted Contributions that include code generation with LLMs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants