Repository navigation
Import external author IDs and links - #116
Merged
Merged
Conversation
This lets us tie the external person to the contributor, even after the user edits it. The idea is that when the user edits the contributor, they're saying "I already have this person in my database, but their name is spelled differently". That's a different use-case from "This is the wrong person, I'm correcting it". I judged the first use-case as more common than the second. It basically comes down to how much I trust the external API.
A previous commit imported external IDs as links, here we import actual URLs from the external API source.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #93