Fix config paths#3583
Conversation
|
Learn Build status updates of commit ff583d9: ✅ Validation status: passed
For more details, please refer to the build report. |
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
There was a problem hiding this comment.
Pull request overview
This PR corrects several documented NuGet configuration file paths across Windows, macOS, and Linux, based on customer feedback and additional repo-wide verification.
Changes:
- Updates the computer-level config locations to distinguish macOS and Linux paths.
- Fixes Linux examples and tables to use the
~/.nuget/NuGet/...and/etc/opt/NuGet/...conventions consistently. - Adjusts
NuGetDefaults.Configlocations to split macOS and Linux guidance.
|
Learn Build status updates of commit 25db681: ✅ Validation status: passed
For more details, please refer to the build report. |
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
| # Set repositoryPath in the computer-level file (requires elevation) | ||
| dotnet nuget config set repositoryPath /home/packages --configfile $XDG_DATA_HOME/NuGet.Config | ||
| # On Linux the computer-level config is under /etc/opt/NuGet/Config; on Mac it's under /Library/Application Support/NuGet/Config | ||
| dotnet nuget config set repositoryPath /home/packages --configfile /etc/opt/NuGet/Config/NuGet.Config |
donnie-msft
left a comment
donnie-msft
left a comment
There was a problem hiding this comment.
Looks good, and I have these questions:
- So, is
XDG_DATA_HOMEnot used by NuGet at all? If it is, should we keep some mention of it? - Does this PR also address NuGet/Home#13596 ?
|
|
||
| # Set repositoryPath in the computer-level file (requires elevation) | ||
| dotnet nuget config set repositoryPath /home/packages --configfile $XDG_DATA_HOME/NuGet.Config | ||
| # On Linux the computer-level config is under /etc/opt/NuGet/Config; on Mac it's under /Library/Application Support/NuGet/Config |
There was a problem hiding this comment.
Should we quote paths for readability?
There was a problem hiding this comment.
Should we delete this part?
On Linux, this previous location was
/etc/opt, and on Mac,/Library/Application Support.
...from
...to potentially fix this issue?
NuGet/Home#13596
in #3576, a customer noticed some of the paths documented were wrong. I pointed copilot at both the docs repo and the NuGet.Client repo, and told it to find all the other errors. This PR are the fixes it found.