Repository navigation
fix(sloplint): preserve before inventory after incomplete renders - #104
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
Refuse to replace before.json after an explicitly requested render is unavailable or fails. Retain static before-mode behavior and run the CLI regression in the existing verification workflow.
|
@rudycelekli is attempting to deploy a commit to the Together AI Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve the before inventory when an explicitly requested browser render fails, only partially succeeds, or cannot run. Currently --before records an empty or partial replacement and exits successfully even after render failure. The command now exits 2 before writing before.json; static --before still records a page with lint findings.
This protects the inventory record, not screenshots already written during an attempted render. The README states the behavior and the existing verify workflow runs the regression alongside its three unchanged gates.
Validation
Prepared with AI assistance under the account owner's explicit direction and independently reviewed by another AI agent. Maintainer review and acceptance remain pending.