Skip to content

fix(sloplint): preserve before inventory after incomplete renders - #104

Open
rudycelekli wants to merge 1 commit into
Nutlope:mainfrom
rudycelekli:fix/before-render-inventory-20261029
Open

rudycelekli wants to merge 1 commit into
Nutlope:mainfrom
rudycelekli:fix/before-render-inventory-20261029

Conversation

@rudycelekli

Copy link
Copy Markdown
Contributor

Summary

Preserve the before inventory when an explicitly requested browser render fails, only partially succeeds, or cannot run. Currently --before records an empty or partial replacement and exits successfully even after render failure. The command now exits 2 before writing before.json; static --before still records a page with lint findings.

This protects the inventory record, not screenshots already written during an attempted render. The README states the behavior and the existing verify workflow runs the regression alongside its three unchanged gates.

Validation

  • The identical regression has five failures and two passing controls on unchanged upstream; the fix passes all seven. It runs the actual CLI with a controlled renderer result boundary, including failed/partial/unavailable/throwing renders, first-run failure, successful replacement, and static mode. No real browser integration is claimed.
  • References: 101 files clean; all 50 themes validate; regenerated theme index has no diff; whitespace checks pass.
  • Tested tree: 5bfbe824307208a2d8e7807501571a3d259786c4, based on 8f6969f. Hosted CI is pending.

Prepared with AI assistance under the account owner's explicit direction and independently reviewed by another AI agent. Maintainer review and acceptance remain pending.

Refuse to replace before.json after an explicitly requested render is unavailable or fails. Retain static before-mode behavior and run the CLI regression in the existing verification workflow.
@vercel

vercel Bot commented Oct 29, 2026

Copy link
Copy Markdown

@rudycelekli is attempting to deploy a commit to the Together AI Team on Vercel.

A member of the Team first needs to authorize it.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant