Repository navigation
fix(theme): accept CRLF frontmatter delimiters - #95
Merged
Merged
Conversation
|
@HelloWorld3326 is attempting to deploy a commit to the Together AI Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A theme saved with CRLF line endings was rejected as having no frontmatter, because the opening delimiter required an immediate LF. Accept both LF and CRLF delimiters.
Validation:
node --test skills/hallmark/scripts/theme.test.mjsfails on CRLF before the fix and passes afterward. The CLI test uses the existing Hum theme, with both variants below the separate 8,000-byte limit, and checks successful validation for both. Source files are not rewritten.