Repository navigation
Conversation
GwnDaan
added this pull request to stack #750
September 29, 2026 12:07
GwnDaan
marked this pull request as ready for review
September 29, 2026 16:07
GwnDaan
requested review from
ad3154 and
martonmiklos
and
a balanced review from Copilot
September 29, 2026 16:07
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The disabled-thread backend currently fails compilation and skips VT parsing, while TC worker reinitialization can terminate the process.
Review effort: Balanced
Findings: 2
Open (3)
What changed in this PR
Adds CMSIS-RTOS2 support to the shared threading abstraction and migrates core worker threads and synchronization primitives.
Changes:
- Implements CMSIS mutex, thread, condition-variable, sleep, and yield wrappers.
- Migrates CAN, VT, and TC workers to the abstraction.
- Adds CMake backend selection and configuration validation.
| File | Description |
|---|---|
CMakeLists.txt |
Adds CMSIS backend selection. |
utility/CMakeLists.txt |
Exposes the CMSIS definition. |
utility/include/isobus/utility/thread_synchronization.hpp |
Implements threading backends. |
isobus/CMakeLists.txt |
Configures Isobus for CMSIS. |
isobus/src/isobus_virtual_terminal_working_set_base.cpp |
Migrates working-set locks. |
isobus/src/isobus_virtual_terminal_server_managed_working_set.cpp |
Migrates parser thread and locks. |
isobus/src/isobus_virtual_terminal_client.cpp |
Migrates the VT worker thread. |
isobus/src/isobus_task_controller_server.cpp |
Migrates server synchronization. |
isobus/src/isobus_task_controller_client.cpp |
Migrates the TC worker thread. |
isobus/include/isobus/isobus/isobus_virtual_terminal_working_set_base.hpp |
Uses abstract mutex type. |
isobus/include/isobus/isobus/isobus_virtual_terminal_server_managed_working_set.hpp |
Uses abstract thread type. |
isobus/include/isobus/isobus/isobus_virtual_terminal_client.hpp |
Uses owned abstract thread. |
isobus/include/isobus/isobus/isobus_task_controller_server.hpp |
Exposes abstract synchronization types. |
isobus/include/isobus/isobus/isobus_task_controller_client.hpp |
Uses owned abstract thread. |
hardware_integration/CMakeLists.txt |
Configures hardware integration for CMSIS. |
hardware_integration/src/can_hardware_interface.cpp |
Migrates CAN worker synchronization. |
hardware_integration/include/isobus/hardware_integration/can_hardware_interface.hpp |
Declares abstract CAN threading members. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Implements the threading intent of #319 and supersedes the approach in #458 on current
main. The goal is to enable embedded RTOS platforms such as Zephyr and FreeRTOS without requiring standard-library threading support.isobusthreading abstraction.std::thread, mutexes, condition variables, sleep, and yield onto that abstraction where needed, including CAN, TC, and VT workers.CAN_STACK_DISABLE_THREADSbehavior. Nonamespace stdchanges._gettimeofdayrequirement; currentmainprovidesTimeSource. Platform-specific CAN and time-source integration remain out of scope.Draft: std and no-thread builds and existing tests pass, and the CMSIS code compiles against Arm and Zephyr CMSIS headers. Zephyr integration builds, hardware testing, and RTOS runtime testing are still pending.