Repository navigation
Report why Windows CAN plugins failed to open through get_last_error - #759
Merged
Merged
Conversation
…the handle on CAN init failure
This was referenced Oct 3, 2026
GwnDaan
reviewed
Oct 6, 2026
|
GwnDaan
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Follow up to #747. The four Windows CAN plugins (PCAN-Basic, TouCAN, SYS TEC, InnoMaker USB2CAN) now override
get_last_error(), so the VT Start alert can show the real reason whenopen()fails.0 < tempHandle, becauseCanalOpenreturns a negative value on error.UCANRETerrors. It also releases the handle if CAN init fails after the hardware init worked.urbSetupDevice(), and drops the secondopenInnoMakerDevice()call that was ignoring its result.