Repository navigation
Preserve CAN port on completed TP/ETP messages - #762
Merged
Merged
Conversation
|
martonmiklos
approved these changes
Oct 4, 2026
ad3154
approved these changes
Oct 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Describe your changes
Fixes #761
Completed TP and ETP messages were created with a hard coded CAN port 0. So on port 1 or higher, destination specific multi-frame messages never reached the partner callbacks. For example a VT Get Versions response with one stored label is 9 bytes, so it goes over TP and was lost.
TransportProtocolManagerandExtendedTransportProtocolManagernow usemessage.get_can_port_index()for the completed message.tempMessageport hack and the TODO inCANNetworkManager. It stopped working after d2d47dd, and the port is now correct at the source.TransportProtocolTest.BroadcastMessageReceivingKeepsCANPort.How has this been tested?
cmake -S . -B build -DBUILD_TESTING=ON -DCAN_DRIVER=SocketCAN
cmake --build build
./build/test/unit_tests --gtest_filter='TransportProtocolTest.*'