Send Load Version response after a restored pool is parsed

[sujandumaru]

Describe your changes

Part of #765.

Before this, the server never answered a pool restored by Load Version (0xD1) with a Load Version response. It sent an End of Object Pool response instead, or left the response to the application.

• update() now sends the Load Version response once the restored pool finishes parsing: no error on success, and an error bit on a parse failure or a missing working set object. That bit is the file system error / pool data corruption bit on VT4+ and the any other error bit on VT3.
• An unknown label now reports bit 1 (version label not correct or unknown). It used to report bit 0.
• An unknown label no longer restarts parsing of a pool the working set already has.
• Added a LoadVersionErrorBit enum so the error bits have names instead of magic numbers.

How has this been tested?

6 new tests in test/vt_server_tests.cpp.

cmake -S . -B build -DBUILD_TESTING=ON
cmake --build build
cd build/test && ctest -R VirtualTerminalServer --output-on-failure

To implement ExtendedLoadVersion, we need to implement ExtendedGetVersions and ExtendedStoreVersion as well. So, I would like to make separate PR for that.

[sujandumaru]

Note: When the load version is requested with no string (all blanks), we are supposed to send last stored version by default as per the standard but we are not doing that here for now.

[GwnDaan]

Nice work!

One thing I noticed is that we are not setting the parsing indicator in the VT status message while any relevant pool is being parsed, and clear it only after the corresponding response has been sent.

Would it be easy to add to this PR or do you prefer a separate PR? I don't mind

[sujandumaru]

Nice work!

One thing I noticed is that we are not setting the parsing indicator in the VT status message while any relevant pool is being parsed, and clear it only after the corresponding response has been sent.

Would it be easy to add to this PR or do you prefer a separate PR? I don't mind

Yes, I was thinking about that in next PR.

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
80.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud