Repository navigation
fix: report actionable error when url input is empty - #16
luojiyin1987 wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe ChangesURL validation
Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: ⚪ Minimal · up to The change provides a clearer failure message for empty URL configuration while preserving the existing fail-fast behavior; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Fixes #15
改动
src/main.ts的post()在发起请求前校验url输入。为空时输出可操作的错误并失败退出:替代原来 undici 抛出的底层错误
No URL protocol specified。设计说明
保持"配置错误即失败"的语义不变,不静默跳过:
if条件里处理(参考 Open-Source-Bazaar.github.io#114)验证
tsc、ncc pack、jest(1/1)、eslint、prettier 通过INPUT_URL:输出上述错误日志,exit 1dist/index.js已随源码重新打包Summary by CodeRabbit