fix: allow editing profile with optional fields - #1467
Open
Tanvinaik09 wants to merge 1 commit into
Open
Conversation
Ensure reset function handles undefined values for displayName, bio, and website.
Author
|
i have fixed the issue, can you please review it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title:
fix: handle undefined optional profile fields
[x] bug fix
Related Issues:
Issue #1466
What this PR achieves:
Fixes the profile edit form validation when optional fields are empty.
Previously, empty profile fields could contain null or undefined values, causing the form to remain invalid even when only one field was updated.
This change normalizes displayName, bio, and website to empty strings when resetting the form, ensuring optional empty fields are handled correctly.
Notes:
The change is limited to normalizing optional profile fields during form reset.