Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short Description
Adds a top-level automatic prompt caching to each planner API call,. This allows later rounds of the tool loop to read earlier rounds, including web search and fetch results, from cache.
Fixes #693
Implementation Details
The original planner only cached the tool definitions and system prompt. The API already caches web results inside a single call, but each new round of the planner's tool loop (
tool_userounds,pause_turncontinuations, the no-tools wrap-up round, the web-downgrade retry) re-sent the wholemessagesarray with no breakpoint in it, so fetched pages were billed again on every round.Changes:
services/global_chat/planner.py: a_HISTORY_CACHEconstant ({"cache_control": {"type": "ephemeral"}}) passed into both the streaming and non-streaming calls in_call_api. The API puts the breakpoint on the last cacheable block and moves it forward each round. This is applied to every planner call.Tests:
test_planner.pycheck thatcache_controlis sent on streamed and non-streamed calls, on every round of a pause -> tool_use -> wrap-up turn, and on the web-downgrade retry.AI Usage
Please disclose whether you've used AI in this work (it's cool, we just want to
know!):
You can read more details in our
Responsible AI Policy