Repository navigation
feat: add action.yml - #16
Merged
Merged
Conversation
josephjclark
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Turns this repo into something Lightning and kit can call directly from their
own CI, so a breaking change on either side shows up on the PR that
introduced it — not just on a manual dispatch here
(lightning#4784's original
ask).
action.ymlis a composite action wrapping the sameprep-and-run sequence the dispatch workflow already did: resolve the specs,
install the toolchain the Lightning checkout pins, boot the pair, run the
suite, upload logs.
The dispatch workflow (test-lightning-branch.yml)
now calls that action (
uses: ./) instead of duplicating its steps, so itdoubles as the action's own test.
How to use and test it
bun run typecheck bun src/cli.ts resolve --lightning ../lightning --worker ../kit # prints {lightning, worker} JSONNot yet run through a real
uses: OpenFn/kit-lightning-integration@...callfrom another repo — that needs a push and a tag (see reviewer guide). Checked
so far: both YAML files parse,
actionlintreports no findings on theworkflow, and
resolveproduces clean JSON on stdout for a local path, abare ref (triggers a clone), and the
owner/repo#refform the workflowitself now passes.
Where to look, in order
(the two caller snippets, the two requirements: caller provides Postgres,
Linux runner).
resolvesubcommand: turns a spec intoa checkout (cloning if needed) without booting anything, prints
{lightning, worker}as JSON. This is the seam the action needed — it hasto know where
.tool-versionslives before it can install thetoolchain, which the old workflow only solved by hardcoding
actions/checkoutinto.cache/lightningitself.log moved to stderr, so
resolve's stdout stays clean JSON for theaction's
jqto parse.— collapsed to checkout + Postgres service +
uses: ./, passingowner/repo#reffor the action to resolve itself.the caller snippet and the
@v1-not-@mainpinning note.