Repository navigation
Conversation
char.ToUpper uses the current culture; on a Turkish-locale machine 'i' upper-cases to U+0130, so the flat path table and collision detection differ from the console's. Behaviour for non-ASCII names on retail is unverified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FlatPathTable.HashFunctionupper-cases withchar.ToUpper, which uses the current culture. On a Turkish-locale machine'i'becomes'İ'(U+0130), so the flat path table (and collision detection) differs from what the console computes for the same path.Fix:
char.ToUpperInvariant. Hashes for ASCII paths are unchanged on every other culture. I checked the algorithm against the flat path tables of two retail-built packages: every path hash matches. They had no non-ASCII names, so the retail behaviour for non-ASCII names is still unverified.Test:
FlatPathTableHashTests.FlatPathTableHash_IsCultureInvariant(file.bin/FILE.BINmust collide under tr-TR). Fails on master.