Repository navigation
Conversation
The console resolves paths case-insensitively, so such pairs are one file there. Seen in practice when merging a base pkg (.xxx) with a patch shipping the same files as .XXX.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a GP4 validator warning for paths that differ only by case.
The console resolves paths case-insensitively (the flat path table hashes upper-cased paths), so
a.xxxandA.XXXare the same file on the console, and which one it opens is undefined. This shows up in practice when a base package and a patch ship the same files with different case (one game's patch has 487.XXXfiles replacing base.xxxfiles).I made it a warning rather than fatal, so existing projects still build. Part of maxton#59-style validation (maxton#59).
Tests:
Gp4ValidatorTests.