Repository navigation
Store raster images in Git LFS - #133
Merged
Merged
Conversation
The press kit is about to carry app screenshots at full device resolution, which would put several megabytes of binaries into the history of a repository whose sources are text. PNG and JPEG are tracked in LFS from here on; SVG stays a normal blob, because it diffs. The Pages workflow checks out with `lfs: true`. Without it the runner writes pointer files, `Resources/` copies them to the site as text and the press kit zips text — and the build still passes, so the failure would only show in a browser.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The press kit is about to carry app screenshots at full device resolution — several megabytes of binaries in the history of a repository whose sources are text.
.gitattributestracks*.png,*.jpgand*.jpeg; SVG stays a normal blob, because it diffslfs: trueThat last point is the one worth reviewing: without it the runner writes pointer files,
Resources/copies them to the site as text and the press kit zips text — and the build still passes, so the failure would only show in a browser.Verified locally that git stores a pointer, the working tree holds the real PNG, and
swift runwrites real images toOutput/and intopresskit.zip.