Repository navigation
Landing page: contrast, mobile reach and target sizes - #134
Merged
Merged
Conversation
The language toggle was hidden below 720 px, leaving no route to the German page on a phone. White on --coral-bright measured 3.19:1 and the dark mode's --rule 1.26:1 against a card, so buttons failed SC 1.4.3 and card edges were effectively gone. The filename in "Keep it." was cut off at the tags, the part the section exists to explain. New tokens split the roles the accent colour was carrying: --accent-fill keeps the darker coral under white text in both modes, --accent-on-sunk carries coral on the sunk surface, --ink-edge gives the dark blocks an edge on dark paper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.language-togglesurvives the 720 px breakpoint, so the German page is reachable on a phone; the header wraps below 333 px instead of scrolling sideways--accent-fillkeeps the darker coral under white text in both modes (white on--coral-brightwas 3.19:1);--accent-on-sunkcarries coral on the sunk surface,--ink-edgegives the dark blocks an edge on dark paper--rulein the dark mode goes from#2c3644to#5a6a86— at 1.26:1 against a card the hairline that forms every group was gonescroll-margin-topon#featuresand#download; the signature types on scroll where the browser supports view timelines↹becomes⇥, "GitHub" in the open-source promise links to the repository, and two mistranslated press quotes are corrected ("data" → "dates", "documents" → "receipts")