Fix staging cache test environment - #3795
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3795 +/- ##
=======================================
Coverage 85.11% 85.11%
=======================================
Files 109 109
Lines 6290 6290
Branches 1093 1093
=======================================
Hits 5354 5354
Misses 630 630
Partials 306 306 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3794
Summary
Root cause
The staging App Engine job defined managed-cache Secret Manager references at job scope. Its earlier
make teststep inherited those references without selecting a cache mode, so the cache loader selected disabled mode and rejected the inconsistent secret configuration during collection. The workflow stopped before image construction or deployment.Impact
The correction affects only the predeployment test process. Actual App Engine and Cloud Run revisions continue to receive deployed-mode managed Redis configuration. Cloud SQL, API routes, compute selection, and the dormant v2 database remain unchanged.
Verification
uv run pytest tests/unit/test_cloud_run_deploy_scripts.py -q— 94 passed.venv/bin/python3 -m pytest tests/unit/test_cloud_run_deploy_scripts.py tests/unit/runtime_cache/test_settings.py -q— 111 passedmake testscope and--collect-only— 1,191 tests collected successfullypython3 scripts/run_quality_guards.py— passedpython3 scripts/export_migration_contracts.py— generated artifacts unchangeduv run ruff format .— unchangeduv run ruff check tests/unit/test_cloud_run_deploy_scripts.py— passed