Repository navigation
Run only the Integrations checks in its doctor tests - #290
Merged
Merged
Conversation
The doctor tests spawned Base's always-on checks too, three Bun scripts and npx, on each doctor call. Under bun test --parallel those process starts pushed the sign-in test past 5 s in CI. The runner now spawns only the Integrations pack's own check commands against the fake CLIs and fails every other command without a process. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
🔵 Merge risk: low · two-way door
bun run typecheckand the pack's tests cover the edit.Problem
The test "the Integrations pack > doctor passes each sign-in once its provider reports it, and lists only the ones still missing" timed out at 5 s in CI three times on 2026-11-19 (on #287 and #286). Each red cleared on a rerun.
The
doctor()helper ran the realcheck()with a runner that spawned every command. That includes Base's always-on checks: three Bun scripts andnpx --version, which starts Node. Each doctor call ran them, and the test calls doctor twice. When everybun test --parallelworker starts at once, these process starts push the test past 5 s.Change
The doctor runner now spawns only the commands of the Integrations pack's own checks, taken from the resolved plan. It answers every other command with exit 1 and starts no process. The test reads only Integrations findings already (
signInsOf).The four real Integrations
sh -cchecks still run against the fakeclaudeandcodexscripts, so the tests still prove the pack's check commands.Proof
Test times from
bun test --reporter=junit, on a devbox, file run alone:A mutation check: changing
grep -qx OAuthtogrep -qx OAuthXin the pack'scontext7-codexcheck fails "doctor passes each sign-in …". So the real check commands still run.A second mutation check: changing
[ -n "$CONTEXT7_API_KEY" ]to[ -n "$CONTEXT7_API_KEYX" ]in the same check fails "doctor accepts a Context7 API key …". So the API-key branch is covered too.bun run typecheckpasses.Impact
Removes a flaky CI red that blocked PR gates and needed reruns.
🤖 Generated with Claude Code
How did you test this code?
d9294e70d51908Not checked: none recorded
Full receipt (PostHog team): https://artifacts.posthog.com/a/0Sb4lXuuI5Q5NLJqvt4Ued