Skip to content

feat(data-warehouse): add a warehouse area to the rail navigation - #113361

Open
EDsCODE wants to merge 37 commits into
masterfrom
feat/today-warehouse-rail
Open

EDsCODE wants to merge 37 commits into
masterfrom
feat/today-warehouse-rail

Conversation

@EDsCODE

@EDsCODE EDsCODE commented Oct 7, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

  • People on the new rail navigation (today-rail-nav) have no single place for the data warehouse.
  • Its tools sit among dozens of others in the Products pane, and nothing shows whether syncs are healthy.
  • This adds a Warehouse area to the rail, behind a new today-rail-warehouse flag that only works together with today-rail-nav.

Changes

  • A Warehouse rail tile opens a new /warehouse home page.
  • The home page shows a getting-started checklist (connect a source, create a view), pipeline health issues, and the five latest runs.
  • Every warehouse page gets a header bar. Quick start and the context panel controls stay in the global top bar from master.
  • The header's menu button names the current page, for example "Definitions". On the home page it says "Warehouse".
  • The menu groups the warehouse tools under Import, Transform, Export and Define, with Data ops last.
  • The warehouse holds the pages that organize data: where it comes from, how it is shaped, and where it goes. Pages for making decisions with data, like BI, stay in the Products pane.
  • Endpoints also stays in the Products pane.
  • The menu adds ELT, managed migrations, event ingestion filtering and warnings, transformations, managed viewsets, destinations, definitions and actions to the warehouse.
  • Those tools leave the Products pane while both flags are on.
  • Warehouse pages with a tab bar show their tabs as rows in a sidebar under the Warehouse header, beside the page.
  • Hiding the sidebar puts the tab bar back in the page, so navigation never disappears.
  • Pages without tabs (home, SQL editor, Sources list) keep the full width.
  • Top-level warehouse pages show actions and scene menus above their content. The Warehouse header names the page; nested resources keep their titles.
  • Nested pages, like one source or one model, keep their title, because the header does not show the resource name.
  • With only today-rail-nav on, the rail behaves as on master. The flag-off UI does not change.

Current master update (October 22): the Warehouse area keeps master's global top bar, More menu, chat view selection, and Products/Analytics pane selection.
Warehouse routing and scene tabs remain behind both feature flags.

Current Warehouse home at 1440px, using synthetic Storybook data:

Warehouse home after the October 22 master update

The earlier Storybook screenshots below use synthetic data and show the layout before the October 22 update.

Definitions: rail flag only Definitions: both flags
Definitions without Warehouse Definitions with Warehouse tabs

Warehouse home at 960px:

Warehouse home at 960px

Earlier screenshots are retained below for the original implementation and menu contents. Their surrounding navigation predates the master update.

Before (today-rail-nav only) After (both flags)
before-models after-models

The after image of the Models page predates the menu button change. The screenshots below show the earlier header before the master update.

The menu and the home page are new surfaces, so they have no before. The menu screenshot replaces an earlier one that showed the ungrouped menu.

Warehouse menu Definitions tabs in the sidebar
menu-crop definitions-crop
Warehouse home
home

How it works:

  • todayWarehouseItems.ts is the single list of warehouse pages. The menu, the route-to-pane mapping and the Products exclusion all read it.
  • An item can claim extra paths. Batch exports, every Definitions tab and ingestion warnings v2 mark the right item that way.
  • /functions and /pipeline/new map to the warehouse pane but to no menu item, because destinations and transformations open them.
  • Web script pages share those routes, so a web script's detail page opens in the warehouse pane too. The route alone cannot tell them apart.
  • SceneTabs replaces LemonTabs in 10 warehouse tab bars. With the flag off it renders LemonTabs unchanged.
  • A data catalog metric keeps its Definition and Lineage tabs in the page, because they switch views of one metric.
  • On a warehouse route with the sidebar open, SceneTabs renders content only (new LemonTabs.barHidden) and portals rows into the sidebar.
  • Scenes publish their own tabs because tab lists depend on loaded data (source type, warehouse status, flags). A static per-route registry could not know them.
  • todaySceneTabsLogic counts mounted SceneTabs. The warehouse pane has a sidebar only while the count is above zero.
  • Under the rail flag, the content column is a grid. The header spans the top row, and the sidebar and the page share the row below.
  • Warehouse tabs have their own grid column. Master's docked context panel keeps its separate column beside the content.
  • The docked context panel uses master's layout; the floating context panel stays available on warehouse pages.
  • On a narrow window the sidebar stays the overlay drawer beside the rail, and phones keep the in-page tab bar.
  • On warehouse pages QuillSceneTitleSection registers the scene's PostHog AI tool, preserving the SQL editor's execute_sql context.
  • QuillSceneTitleSection renders actions and the scene menu slot on a top-level warehouse page. It reads the page from the new currentWarehouseItem selector, which the header and the drawer title share.
  • A 300 ms hold keeps the sidebar open between two tabbed pages, so the content does not jump.
  • Cmd/Ctrl+B does nothing on a warehouse page without tabs. Tabbed pages reuse the current sidebar hide and reopen controls.
  • initKea.ts adds the home page's two loaders to the toast allow-list, because the page shows its own inline retry.

Warning

Navigation.tsx wraps the content column so the Warehouse header and tabs can sit beside <main> without remounting it. The wrapper affects both flag states. It preserves master's top bar, docked context panel, and takeover layout. Review this part first.

Mechanical: one existing FEATURE_FLAGS entry (METRICS_DASHBOARD_CONTROLS) moves into sorted order, because the pre-push sort check fails on master's current order. The visual review baselines for the TodayWarehouseHeader stories change with the new menu button.

How did you test this code?

The October 22 master update passes the six focused frontend suites, frontend typechecking, route manifest generation, MCP URL/schema tests, and strict pre-push checks.
Storybook browser checks cover the home page, menu, Definitions sidebar hide/reopen, and 1440px/960px layouts with no uncaught page errors.
The routing tests also cover warehouse navigation alongside master's Products/Analytics pane selection. Full CI remains authoritative.

  • Jest covers both flag states for route mapping, the Products exclusion and the sidebar rules.
  • Jest also covers the sidebar hold timer, the sidebar rows, and the home page logic (step states, issue filtering, run dedupe, per-section failures).
  • Route tests cover the new menu items, their extra paths, the function routes, and BI, Endpoints and annotations staying in the Products pane.
  • Storybook full-app renders produced the Models pair and the home page screenshot.
  • The live local app on the current branch produced the menu and Definitions screenshots.
  • In the live app, BI, Endpoints and annotations open in the Products pane, and /pipeline/new/destination keeps the warehouse header.
  • In the live app, the header holds at 1440 and 900 px wide, and the phone layout takes over at 700 px.
  • Not checked: the flag-gated menu items (ELT, warehouse destinations, managed viewsets, Data ops) in the live app, the home page with real failing syncs, and phone layouts beyond the logic tests.

Test rationale: Each new case guards a rule a later change could break silently: route-to-pane mapping per flag, the Products exclusion per flag, the sidebar hold timer, and per-section failure on the home page. The nearest existing tests (todayShellLogic.test.ts, toolsLogic.test.ts) were extended rather than duplicated. Logic tests cover this, so no browser test is needed.

Release status

  • This change is behind a feature flag and is not available to users

Docs update

None. The change sits behind two flags, and no existing doc covers the rail navigation.

🤖 Agent context

Autonomy: Human-driven (agent-assisted)

Agent: Claude Code (Claude Opus 5.5, Claude Sonnet 5.5, and Claude Fable 5.1) wrote the original implementation. Codex (GPT-6) resolved the current master merge and validated the update.

  • Skills invoked: /writing-ui-components, /placing-product-frontend-code, /writing-tests, /writing-code-comments, /writing-user-facing-copy, /writing-pr-descriptions, /reviewing-with-coderabbit, /run-posthog, plus the superpowers brainstorming, planning and subagent-driven-development workflows.
  • The master update preserves Analytics, Chats, Settings, sidebar pinning, scene menus, and the new top bar. The unrelated dashboard snapshot change was dropped.
  • Update skills: /signed-git-publish, /hogli, /running-ci-preflight, /debugging-ci-failures, /writing-ui-components, /writing-kea-logics, /using-kea-disposables, /writing-tests, /writing-code-comments, /setting-feature-flags-in-storybook, /writing-user-facing-copy, /writing-pr-descriptions, /reviewing-with-coderabbit, and /run-posthog.
  • Scope changes during the session: Lineage left the menu, the second flag split the work from today-rail-nav, and the rebase moved warehouse routes from the old Tools pane onto the Products pane.
  • Endpoints and Notebooks left the warehouse area after the first review. Endpoints stays in the Products pane and Notebooks in the Views pane.
  • The home page lost its notebook "Explore your data" step with Notebooks.
  • In QA, the sidebar moved from beside the rail to under the Warehouse header, top-level pages dropped their scene title and description, and Quick start and the context panel toggle moved into the header.
  • A later pass split the warehouse from Products by purpose. The menu gained its groups and the import, transform, export and define pages, and BI went back to Products. Endpoints came back under Export for one commit, then went back to Products at the person's request.
  • The same pass made the menu button an elevated outline button that names the current page.
  • Fable reviewed that pass. Its findings kept the function routes in the warehouse pane, fixed truncation of long page names in the button, and renamed the ELT item to match the Products pane.
  • Duplicate search: no open PR matches "warehouse rail" or today-rail-warehouse.
  • Public artifact: all fixtures are invented. The screenshots show Storybook mocks or the local demo project's generated data. Nothing came from customer material.

🤖 Generated with Claude Code

Behind today-rail-nav plus the new today-rail-warehouse flag:
- a Warehouse rail tile that opens a new /warehouse home page
  (getting started checklist, pipeline health, recent runs)
- a Warehouse header menu on every warehouse page; its tools leave
  the Products pane
- warehouse scenes with tab bars show those tabs in a sidebar beside
  the rail, falling back to the in-page bar when the sidebar is hidden

With only today-rail-nav on, the rail behaves as before.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@EDsCODE EDsCODE self-assigned this Oct 7, 2026
@trunk-io

trunk-io Bot commented Oct 7, 2026

Copy link
Copy Markdown

Merging to master in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

@EDsCODE EDsCODE added the skip-inkeep-docs Use this label to skip an Inkeep docs PR in posthog.com label Oct 7, 2026
@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

🤖 CI report

⚠️ Trunk lane — backend Python lane

This PR is assigned to the backend Python lane. It runs backend Python tests and may merge in parallel with PRs in other lanes.

⚠️ Complexity (TypeScript) — 12 functions above the limit (max 55)

Cyclomatic complexity above the limit in changed typescript files (10 for production files, 15 for test files). Warn only: worth simplifying when you next touch these functions.

Function Location Complexity Limit
QuillSceneTitleSection frontend/src/layout/scenes/components/QuillSceneTitleSection.tsx:30 55 10
onFailure frontend/src/initKea.ts:344 47 10
railPaneForPath frontend/src/layout/today/todayShellLogic.ts:137 26 10
HogFunctionScene frontend/src/scenes/hog-functions/HogFunctionScene.tsx:499 24 10
<anonymous> frontend/src/scenes/hog-functions/HogFunctionScene.tsx:219 21 10
SchemaSceneContent products/data_warehouse/frontend/scenes/SchemaScene/SchemaScene.tsx:66 19 10
TodayShell frontend/src/layout/today/TodayShell.tsx:78 16 10
insightNew frontend/src/products.tsx:1948 15 10
<anonymous> frontend/src/lib/lemon-ui/LemonTabs/LemonTabs.tsx:106 14 10
BatchExportSceneContentInner frontend/src/scenes/data-pipelines/batch-exports/BatchExportScene.tsx:254 14 10
ManagedSourceTabs products/data_warehouse/frontend/scenes/SourceScene/SourceScene.tsx:285 14 10
<anonymous> products/data_warehouse/frontend/scenes/SourceScene/SourceScene.tsx:311 12 10
❌ Duplication (Python) — the duplication scan could not run

The duplication scan failed on this run (see the job log). Nothing here says whether this branch adds duplication.

❌ Duplication (TypeScript) — the duplication scan could not run

The duplication scan failed on this run (see the job log). Nothing here says whether this branch adds duplication.

✅ Comment density — 3% of added code lines are comments (61 of 2259)

This section warns when comments are more than 3% of the code lines a PR adds, and alerts above 6%. Before agent-assisted PRs, the typical share was about 2%. Only full-line comments count. Docstrings, generated files, snapshots, migrations, and workflow files are left out.

Comments that restate the code, record how the change came about, or narrate the next line add noise for the next reader. Keep the comments that explain a reason the code cannot show, and remove the rest. See .agents/skills/writing-code-comments/SKILL.md for the house rules.

Files with the most added comment lines:

File Comment lines Added lines
frontend/src/layout/today/todayWarehouseItems.ts 10 235
products/data_warehouse/frontend/scenes/WarehouseHomeScene/warehouseHomeLogic.ts 10 203
frontend/src/layout/navigation-3000/components/MainContentColumn.tsx 6 42
frontend/src/layout/today/todaySceneTabsLogic.ts 4 89
frontend/src/layout/scenes/components/SceneTabs.tsx 3 38
frontend/src/layout/today/TodayWarehouseHeader.tsx 3 118
frontend/src/layout/scenes/components/QuillSceneTitleSection.tsx 2 29
frontend/src/layout/today/todayShellLogic.test.ts 2 128

This check does not block merging. It updates on every push and clears when the share drops.

⚠️ Call assertions — 2 added test lines assert on mock calls (Δ +2 vs base)

This section warns when a PR adds more call assertions to tests than it removes. A call assertion checks that a mock was called, how often, or with which arguments, such as toHaveBeenCalledWith or assert_called_once_with.

A call assertion on a collaborator inside the code under test breaks on every refactor, and it does not prove that a real receiver gets the result. Assert on the observable outcome instead, such as the response, the stored row, or the delivered message, through a real dependency or a faithful fake. Stub a dependency only to inject a fault, and still assert on the outcome.

When the mock stands in for the unit's only real output, such as an outbound HTTP call, a produced message, or a queued job, its calls are the outcome rather than plumbing. A fake that records what it receives, such as a local HTTP server or an in-memory queue, checks the same outcome and survives a refactor.

Files with the most added call assertions:

File Added Δ vs base
frontend/src/layout/today/TodaySceneTabsList.test.tsx 2 +2

This check does not block merging. It updates on every push and clears when the PR no longer adds more call assertions than it removes.

⚠️ Bundle size — 🔺 +60.2 KiB (+0.1%)

Uncompressed size of every built .js bundle, compared against the base branch.

Total: 81.16 MiB · 🔺 +60.2 KiB (+0.1%)

File Size Δ vs base
posthog-app/_parent/products/data_warehouse/frontend/scenes/WarehouseHomeScene/WarehouseHomeScene.js 15.7 KiB 🔺 +15.7 KiB (new)
posthog-app/src/layout/today/TodayWarehouseHeader.js 6.9 KiB 🔺 +6.9 KiB (new)
render-query/src/render-query/render-query.js 22.10 MiB 🔺 +5.3 KiB (+0.0%)
posthog-app/_parent/products/dashboards_v2/frontend/DashboardV2Scene.js 30.6 KiB 🔺 +2.7 KiB (+9.6%)
posthog-app/src/scenes/max/MaxToolRegistration.js 2.1 KiB 🔺 +2.1 KiB (new)
exporter/src/scenes/max/MaxToolRegistration.js 1.5 KiB 🔺 +1.5 KiB (new)
exporter/src/exporter/scenes/ExporterNotebookScene.js 3.92 MiB 🔺 +1.4 KiB (+0.0%)
posthog-app/src/scenes/AuthenticatedShell.js 152.4 KiB 🔺 +1.0 KiB (+0.7%)
posthog-app/src/layout/today/TodayShell.js 39.8 KiB 🟢 -1.0 KiB (-2.5%)

Posted automatically by build-bundle-size-report · uncompressed bytes from dist-report

⚠️ Eager graph — 1 over budget

How much code each root ships on the eager path — downloaded and parsed before the surface is interactive. Measured from the esbuild output chunks (post-tree-shake, static imports only); lazy import() / React.lazy chunks are not counted.

Root Eager (shipped) Δ vs base Budget
entry (logged-out pages, app bootstrap)
src/index.tsx
1.06 MiB · 26 files 🔺 +329 B (+0.0%) █████████░ 93.0% of 1.14 MiB
logged-out boot: index + App + bootApp (preloaded by every page, including /login)
src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
2.88 MiB · 533 files 🔺 +761 B (+0.0%) ██████████ 99.7% of 2.89 MiB
🟡 authenticated shell (every logged-in page)
src/scenes/AuthenticatedShell.tsx
3.95 MiB · 1,237 files 🔺 +7.0 KiB (+0.2%) ██████████ 101.0% of 3.91 MiB
dashboard scene
src/scenes/dashboard/Dashboard.tsx
7.53 MiB · 2,965 files 🔺 +7.3 KiB (+0.1%) ██████████ 95.2% of 7.92 MiB
today home path
src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/today/TodayHome.tsx
4.57 MiB · 1,695 files 🔺 +7.3 KiB (+0.2%) █████████░ 93.5% of 4.88 MiB
AI-first home path
src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/ai-first/AiFirstHomepage.tsx
5.99 MiB · 2,218 files 🔺 +7.3 KiB (+0.1%) ██████████ 97.8% of 6.13 MiB
events scene
src/scenes/activity/explore/EventsScene.tsx
6.47 MiB · 2,399 files 🔺 +7.3 KiB (+0.1%) █████████░ 93.7% of 6.91 MiB
web analytics scene
src/scenes/web-analytics/WebAnalyticsScene.tsx
7.58 MiB · 2,825 files 🔺 +7.3 KiB (+0.1%) ██████████ 95.3% of 7.96 MiB
replay detail scene
src/scenes/session-recordings/detail/SessionRecordingDetail.tsx
6.77 MiB · 2,488 files 🔺 +653 B (+0.0%) ██████████ 95.5% of 7.09 MiB

🟢 node_modules/monaco-editor/ stays out of src/index.tsx
🟢 products/product_analytics/frontend/insights/activityDescriptions stays out of src/index.tsx
🟢 node_modules/@posthog/brand/dist/generated/hoggies/svg/ stays out of src/index.tsx
🟢 node_modules/@posthog/brand/dist/generated/hoggies/components/ stays out of src/index.tsx
🟢 node_modules/monaco-editor/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/lib/lemon-ui/LemonTable/LemonTable.tsx stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 node_modules/@dnd-kit/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/layout/navigation-3000/navigationLogic.tsx stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/scenes/dashboard/dashboardLogic.tsx stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/lib/lemon-ui/LemonMarkdown/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/lib/components/RichContentEditor/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/lib/components/CodeSnippet/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/taxonomy/core-filter-definitions-by-group.json stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 node_modules/zod/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/lib/logic/billing/billingLogic.tsx stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/lib/components/ProductEmptyState/productSetupPreloadLogic.ts stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 node_modules/kea-test-utils/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 node_modules/monaco-editor/ stays out of src/scenes/AuthenticatedShell.tsx
🟢 products/product_analytics/frontend/insights/activityDescriptions stays out of src/scenes/AuthenticatedShell.tsx
🟢 node_modules/kea-test-utils/ stays out of src/scenes/AuthenticatedShell.tsx
🟢 products/dashboards/frontend/widgets/previews/ stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/scenes/session-recordings/player/sessionRecordingPlayerLogic.ts stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/layout/panel-layout/ProjectTree/menus/SessionReplayMenuItems.tsx stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/taxonomy/core-filter-definitions-by-group.json stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/layout/navigation/projectNoticeLogic.tsx stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/layout/navigation/ImpersonationNotice/ImpersonationNotice.tsx stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/toolbar/shared/toolbarConfigLogic.ts stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/toolbar/shared/toolbarFetch.ts stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/scenes/cohorts/cohortSavedToast.ts stays out of src/scenes/AuthenticatedShell.tsx
🟢 products/wizard/frontend/runs/WizardRunDetailsDrawer.tsx stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/layout/today/TodayShell.tsx stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/layout/today/TodayContextPanelFloating.tsx stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/layout/today/TodaySidePanel.tsx stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/layout/today/TodayTopBar.tsx stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/layout/today/todayRailItems.tsx stays out of src/scenes/AuthenticatedShell.tsx
🟢 products/subscriptions/frontend/components/Subscriptions/exportNudge/exportNudgeLogic.ts stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/scenes/billing/paymentEntryLogic.ts stays out of src/scenes/AuthenticatedShell.tsx
🟢 products/conversations/frontend/components/SidePanel/sidepanelTicketsLogic.ts stays out of src/scenes/AuthenticatedShell.tsx
🟢 node_modules/zod/ stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/scenes/authentication/auth/loginLogic.ts stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/scenes/authentication/shared/passkeyLogic.ts stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/scenes/cohorts/CohortFilters/constants.tsx stays out of src/scenes/AuthenticatedShell.tsx
🟢 products/persons/frontend/logics/personsLogic.tsx stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/scenes/surveys/constants.tsx stays out of src/scenes/AuthenticatedShell.tsx
🟢 node_modules/@tiptap/ stays out of src/scenes/AuthenticatedShell.tsx
🟢 node_modules/prosemirror- stays out of src/scenes/AuthenticatedShell.tsx
🟢 node_modules/re2js/ stays out of src/scenes/AuthenticatedShell.tsx
🟢 node_modules/react-markdown/ stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/lib/components/Command/Command.tsx stays out of src/scenes/AuthenticatedShell.tsx
🟢 packages/quill/packages/ stays out of src/scenes/AuthenticatedShell.tsx
🟢 zod/v4/locales/de.js stays out of src/scenes/AuthenticatedShell.tsx
🟢 node_modules/@posthog/brand/dist/generated/hoggies/svg/ stays out of src/scenes/AuthenticatedShell.tsx
🟢 node_modules/@posthog/brand/dist/generated/hoggies/components/ stays out of src/scenes/AuthenticatedShell.tsx
🟢 packages/quill/packages/quill/dist/ stays out of src/scenes/dashboard/Dashboard.tsx
🟢 node_modules/@tiptap/ stays out of src/scenes/dashboard/Dashboard.tsx
🟢 node_modules/prosemirror- stays out of src/scenes/dashboard/Dashboard.tsx
🟢 node_modules/marked/ stays out of src/scenes/dashboard/Dashboard.tsx
🟢 node_modules/frimousse/ stays out of src/scenes/dashboard/Dashboard.tsx
🟢 src/scenes/session-recordings/playlist/SessionRecordingsPlaylist.tsx stays out of src/scenes/dashboard/Dashboard.tsx
🟢 src/scenes/web-analytics/tiles/WebAnalyticsTile.tsx stays out of src/scenes/dashboard/Dashboard.tsx
🟢 src/queries/validators.js stays out of src/scenes/dashboard/Dashboard.tsx
🟢 src/queries/web-analytics-validators.js stays out of src/scenes/dashboard/Dashboard.tsx
🟢 node_modules/re2js/ stays out of src/scenes/dashboard/Dashboard.tsx
🟢 node_modules/kea-test-utils/ stays out of src/scenes/dashboard/Dashboard.tsx
🟢 src/scenes/debug/HogDebug.tsx stays out of src/scenes/dashboard/Dashboard.tsx
🟢 src/queries/QueryEditor/QueryEditor.tsx stays out of src/scenes/dashboard/Dashboard.tsx
🟢 packages/quill/packages/quill/dist/ stays out of src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/today/TodayHome.tsx
🟢 src/scenes/project-homepage/ai-first/AiFirstHomepage.tsx stays out of src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/today/TodayHome.tsx
🟢 src/scenes/project-homepage/today/TodayReportPage.tsx stays out of src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/today/TodayHome.tsx
🟢 src/queries/Query/Query.tsx stays out of src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/today/TodayHome.tsx
🟢 packages/quill/packages/charts/ stays out of src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/today/TodayHome.tsx
🟢 products/posthog_ai/frontend/logics/runStreamLogic.ts stays out of src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/today/TodayHome.tsx
🟢 packages/quill/packages/quill/dist/ stays out of src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/ai-first/AiFirstHomepage.tsx
🟢 products/posthog_ai/frontend/components/tool/widgets/VisualizationWidget.tsx stays out of src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/ai-first/AiFirstHomepage.tsx
🟢 products/posthog_ai/frontend/components/tool/widgets/RecordingsWidget.tsx stays out of src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/ai-first/AiFirstHomepage.tsx
🟢 src/queries/Query/Query.tsx stays out of src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/ai-first/AiFirstHomepage.tsx
🟢 products/posthog_ai/frontend/api/primitives.ts stays out of src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/ai-first/AiFirstHomepage.tsx
🟢 src/scenes/notebooks/Notebook/notebookLogic.ts stays out of src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/ai-first/AiFirstHomepage.tsx
🟢 packages/quill/packages/quill/dist/ stays out of src/scenes/activity/explore/EventsScene.tsx
🟢 node_modules/@tiptap/ stays out of src/scenes/activity/explore/EventsScene.tsx
🟢 node_modules/prosemirror- stays out of src/scenes/activity/explore/EventsScene.tsx
🟢 node_modules/marked/ stays out of src/scenes/activity/explore/EventsScene.tsx
🟢 node_modules/frimousse/ stays out of src/scenes/activity/explore/EventsScene.tsx
🟢 src/scenes/session-recordings/playlist/SessionRecordingsPlaylist.tsx stays out of src/scenes/activity/explore/EventsScene.tsx
🟢 src/scenes/web-analytics/tiles/WebAnalyticsTile.tsx stays out of src/scenes/activity/explore/EventsScene.tsx
🟢 src/queries/validators.js stays out of src/scenes/activity/explore/EventsScene.tsx
🟢 src/queries/web-analytics-validators.js stays out of src/scenes/activity/explore/EventsScene.tsx
🟢 node_modules/re2js/ stays out of src/scenes/activity/explore/EventsScene.tsx
🟢 node_modules/kea-test-utils/ stays out of src/scenes/activity/explore/EventsScene.tsx
🟢 src/queries/nodes/InsightViz/InsightViz.tsx stays out of src/scenes/activity/explore/EventsScene.tsx
🟢 src/queries/nodes/DataVisualization/DataVisualization.tsx stays out of src/scenes/activity/explore/EventsScene.tsx
🟢 src/queries/nodes/WebOverview/WebOverview.tsx stays out of src/scenes/activity/explore/EventsScene.tsx
🟢 src/scenes/debug/HogDebug.tsx stays out of src/scenes/activity/explore/EventsScene.tsx
🟢 src/queries/QueryEditor/QueryEditor.tsx stays out of src/scenes/activity/explore/EventsScene.tsx
🟢 packages/quill/packages/quill/dist/ stays out of src/scenes/web-analytics/WebAnalyticsScene.tsx
🟢 node_modules/@tiptap/ stays out of src/scenes/web-analytics/WebAnalyticsScene.tsx
🟢 node_modules/prosemirror- stays out of src/scenes/web-analytics/WebAnalyticsScene.tsx
🟢 node_modules/marked/ stays out of src/scenes/web-analytics/WebAnalyticsScene.tsx
🟢 node_modules/frimousse/ stays out of src/scenes/web-analytics/WebAnalyticsScene.tsx
🟢 src/scenes/web-analytics/LiveMetricsDashboard/LiveWebAnalyticsMetrics.tsx stays out of src/scenes/web-analytics/WebAnalyticsScene.tsx
🟢 products/product_analytics/frontend/insights/trends/WorldMap/countryVectors.tsx stays out of src/scenes/web-analytics/WebAnalyticsScene.tsx
🟢 src/queries/validators.js stays out of src/scenes/web-analytics/WebAnalyticsScene.tsx
🟢 node_modules/re2js/ stays out of src/scenes/web-analytics/WebAnalyticsScene.tsx
🟢 node_modules/kea-test-utils/ stays out of src/scenes/web-analytics/WebAnalyticsScene.tsx
🟢 src/scenes/debug/HogDebug.tsx stays out of src/scenes/web-analytics/WebAnalyticsScene.tsx
🟢 src/queries/QueryEditor/QueryEditor.tsx stays out of src/scenes/web-analytics/WebAnalyticsScene.tsx
🟢 packages/quill/packages/quill/dist/ stays out of src/scenes/session-recordings/detail/SessionRecordingDetail.tsx
🟢 node_modules/@tiptap/ stays out of src/scenes/session-recordings/detail/SessionRecordingDetail.tsx
🟢 node_modules/prosemirror- stays out of src/scenes/session-recordings/detail/SessionRecordingDetail.tsx
🟢 node_modules/marked/ stays out of src/scenes/session-recordings/detail/SessionRecordingDetail.tsx
🟢 src/scenes/settings/SettingsMap.tsx stays out of src/scenes/session-recordings/detail/SessionRecordingDetail.tsx
🟢 @jspm/core/nodelibs/browser/fs stays out of src/scenes/session-recordings/detail/SessionRecordingDetail.tsx
🟢 node_modules/re2js/ stays out of src/scenes/session-recordings/detail/SessionRecordingDetail.tsx
🟢 node_modules/kea-test-utils/ stays out of src/scenes/session-recordings/detail/SessionRecordingDetail.tsx
🟢 node_modules/d3/src/ stays out of src/scenes/session-recordings/detail/SessionRecordingDetail.tsx

Largest files eagerly shipped from src/index.tsx
Size File
126.7 KiB ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js
24.5 KiB ../node_modules/.pnpm/buffer@6.0.3/node_modules/buffer/index.js
6.3 KiB ../node_modules/.pnpm/react@18.3.1/node_modules/react/cjs/react.production.min.js
4.8 KiB ../node_modules/.pnpm/@jspm+core@2.1.0/node_modules/@jspm/core/nodelibs/browser/process.js
4.0 KiB ../node_modules/.pnpm/scheduler@0.23.2/node_modules/scheduler/cjs/scheduler.production.min.js
1.9 KiB src/lib/utils/bootTiming.ts
1.7 KiB ../node_modules/.pnpm/base64-js@1.5.1/node_modules/base64-js/index.js
1.7 KiB src/index.tsx
1.2 KiB src/RootErrorBoundary.tsx
1.1 KiB src/lib/utils/deferredAppContext.ts
Largest files eagerly shipped from src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
Size File
366.2 KiB ../node_modules/.pnpm/posthog-js@1.450.0_@types+react@18.3.31_react@18.3.1/node_modules/posthog-js/dist/module.mjs
224.8 KiB ../node_modules/.pnpm/@posthog+icons@0.40.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js
126.7 KiB ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js
110.8 KiB src/products.tsx
93.0 KiB src/lib/api.ts
68.9 KiB src/lib/lemon-ui/icons/icons.tsx
36.4 KiB ../node_modules/.pnpm/kea@4.0.0-pre.6_patch_hash=139b8d1f1304f9d9da452a9a1244c94ea679dbcb85687d8999563146879fb6f5_react@18.3.1/node_modules/kea/lib/index.cjs.js
30.5 KiB src/lib/constants.tsx
24.7 KiB ../node_modules/.pnpm/fuse.js@7.3.0/node_modules/fuse.js/dist/fuse.mjs
24.5 KiB ../node_modules/.pnpm/buffer@6.0.3/node_modules/buffer/index.js
Largest files eagerly shipped from src/scenes/AuthenticatedShell.tsx
Size File
366.2 KiB ../node_modules/.pnpm/posthog-js@1.450.0_@types+react@18.3.31_react@18.3.1/node_modules/posthog-js/dist/module.mjs
224.8 KiB ../node_modules/.pnpm/@posthog+icons@0.40.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js
126.7 KiB ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js
110.8 KiB src/products.tsx
93.0 KiB src/lib/api.ts
68.9 KiB src/lib/lemon-ui/icons/icons.tsx
40.3 KiB ../node_modules/.pnpm/@dnd-kit+core@6.3.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@dnd-kit/core/dist/core.esm.js
36.4 KiB ../node_modules/.pnpm/kea@4.0.0-pre.6_patch_hash=139b8d1f1304f9d9da452a9a1244c94ea679dbcb85687d8999563146879fb6f5_react@18.3.1/node_modules/kea/lib/index.cjs.js
32.7 KiB src/lib/utils/eventUsageLogic.ts
30.5 KiB src/lib/constants.tsx
Largest files eagerly shipped from src/scenes/dashboard/Dashboard.tsx
Size File
366.2 KiB ../node_modules/.pnpm/posthog-js@1.450.0_@types+react@18.3.31_react@18.3.1/node_modules/posthog-js/dist/module.mjs
224.8 KiB ../node_modules/.pnpm/@posthog+icons@0.40.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js
126.7 KiB ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js
110.8 KiB src/products.tsx
110.4 KiB ../node_modules/.pnpm/posthog-js@1.450.0_@types+react@18.3.31_react@18.3.1/node_modules/posthog-js/dist/surveys-preview.js
93.0 KiB src/lib/api.ts
84.8 KiB src/scenes/dashboard/dashboardLogic.tsx
68.9 KiB src/lib/lemon-ui/icons/icons.tsx
68.0 KiB ../products/posthog_ai/frontend/logics/runStreamLogic.ts
44.5 KiB src/scenes/surveys/surveyLogic.tsx
Largest files eagerly shipped from src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/today/TodayHome.tsx
Size File
366.2 KiB ../node_modules/.pnpm/posthog-js@1.450.0_@types+react@18.3.31_react@18.3.1/node_modules/posthog-js/dist/module.mjs
224.8 KiB ../node_modules/.pnpm/@posthog+icons@0.40.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js
126.7 KiB ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js
110.8 KiB src/products.tsx
93.0 KiB src/lib/api.ts
68.9 KiB src/lib/lemon-ui/icons/icons.tsx
40.3 KiB ../node_modules/.pnpm/@dnd-kit+core@6.3.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@dnd-kit/core/dist/core.esm.js
36.4 KiB ../node_modules/.pnpm/kea@4.0.0-pre.6_patch_hash=139b8d1f1304f9d9da452a9a1244c94ea679dbcb85687d8999563146879fb6f5_react@18.3.1/node_modules/kea/lib/index.cjs.js
32.7 KiB src/lib/utils/eventUsageLogic.ts
30.5 KiB src/lib/constants.tsx
Largest files eagerly shipped from src/scenes/AuthenticatedShell.tsx + src/scenes/project-homepage/ProjectHomepage.tsx + src/scenes/project-homepage/ai-first/AiFirstHomepage.tsx
Size File
366.2 KiB ../node_modules/.pnpm/posthog-js@1.450.0_@types+react@18.3.31_react@18.3.1/node_modules/posthog-js/dist/module.mjs
224.8 KiB ../node_modules/.pnpm/@posthog+icons@0.40.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js
126.7 KiB ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js
110.8 KiB src/products.tsx
93.0 KiB src/lib/api.ts
68.9 KiB src/lib/lemon-ui/icons/icons.tsx
68.0 KiB ../products/posthog_ai/frontend/logics/runStreamLogic.ts
42.1 KiB src/scenes/hog-functions/sub-templates/sub-templates.ts
40.3 KiB ../node_modules/.pnpm/@dnd-kit+core@6.3.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@dnd-kit/core/dist/core.esm.js
36.7 KiB src/lib/components/TaxonomicFilter/taxonomicFilterLogic.tsx
Largest files eagerly shipped from src/scenes/activity/explore/EventsScene.tsx
Size File
366.2 KiB ../node_modules/.pnpm/posthog-js@1.450.0_@types+react@18.3.31_react@18.3.1/node_modules/posthog-js/dist/module.mjs
224.8 KiB ../node_modules/.pnpm/@posthog+icons@0.40.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js
126.7 KiB ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js
110.8 KiB src/products.tsx
93.0 KiB src/lib/api.ts
84.8 KiB src/scenes/dashboard/dashboardLogic.tsx
68.9 KiB src/lib/lemon-ui/icons/icons.tsx
68.0 KiB ../products/posthog_ai/frontend/logics/runStreamLogic.ts
44.5 KiB src/scenes/surveys/surveyLogic.tsx
40.3 KiB ../node_modules/.pnpm/@dnd-kit+core@6.3.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@dnd-kit/core/dist/core.esm.js
Largest files eagerly shipped from src/scenes/web-analytics/WebAnalyticsScene.tsx
Size File
366.2 KiB ../node_modules/.pnpm/posthog-js@1.450.0_@types+react@18.3.31_react@18.3.1/node_modules/posthog-js/dist/module.mjs
224.8 KiB ../node_modules/.pnpm/@posthog+icons@0.40.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js
126.7 KiB ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js
110.8 KiB src/products.tsx
110.4 KiB ../node_modules/.pnpm/posthog-js@1.450.0_@types+react@18.3.31_react@18.3.1/node_modules/posthog-js/dist/surveys-preview.js
93.0 KiB src/lib/api.ts
84.8 KiB src/scenes/dashboard/dashboardLogic.tsx
68.9 KiB src/lib/lemon-ui/icons/icons.tsx
68.0 KiB ../products/posthog_ai/frontend/logics/runStreamLogic.ts
49.4 KiB src/scenes/web-analytics/webAnalyticsLogic.tsx
Largest files eagerly shipped from src/scenes/session-recordings/detail/SessionRecordingDetail.tsx
Size File
366.2 KiB ../node_modules/.pnpm/posthog-js@1.450.0_@types+react@18.3.31_react@18.3.1/node_modules/posthog-js/dist/module.mjs
333.0 KiB ../node_modules/.pnpm/posthog-js@1.450.0_@types+react@18.3.31_react@18.3.1/node_modules/posthog-js/dist/rrweb.js
224.8 KiB ../node_modules/.pnpm/@posthog+icons@0.40.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js
126.7 KiB ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js
110.8 KiB src/products.tsx
93.0 KiB src/lib/api.ts
68.9 KiB src/lib/lemon-ui/icons/icons.tsx
68.0 KiB ../products/posthog_ai/frontend/logics/runStreamLogic.ts
44.4 KiB src/scenes/session-recordings/player/sessionRecordingPlayerLogic.ts
40.3 KiB ../node_modules/.pnpm/@dnd-kit+core@6.3.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@dnd-kit/core/dist/core.esm.js

Posted automatically by check-eager-graph · sizes are eager output bytes (shipped, post-tree-shake) from the esbuild metafile · part of #32479

✅ Frontend layers — no new upward imports, 0 removed

Static imports from a lower frontend layer into a higher one (layers, lowest first: kernel, shell, query, features). Compared with the base branch, so an import that a PR also adds to layer-baseline.txt still shows here. Sizes are the source bytes on the eager path of every logged-in page.

Layer Eager source bytes Δ vs base
kernel 3.09 MiB 🔺 +732 B (+0.0%)
shell 2.48 MiB 🔺 +17.8 KiB (+0.7%)
query 56.9 KiB no change
features 167.9 KiB no change

Download the interactive layer graph for this PR.

Posted automatically by check-layers

✅ Toolbar bundle — eager 2.47 MiB within budget

What the toolbar ships to customer pages, measured from the esbuild output (minified, post-tree-shake). The eager set is the entry plus everything statically imported from it — fetched before any feature runs; deferred chunks load lazily. The eager guardrail is 5.72 MiB. Each output file must also stay below 10 MB, where CloudFront stops compressing it. The module boundary is enforced separately by check-toolbar-graph.

Metric Size Δ vs base Budget
Eager (shipped)
entry + static imports
2.47 MiB · 21 files 🔺 +402 B (+0.0%) ████░░░░░░ 43.1% of 5.72 MiB
Deferred (lazy) 2.21 MiB · 44 files no change n/a — loads on demand
Loader dist/toolbar.js 1.2 KiB no change █░░░░░░░░░ 6.0% of 19.5 KiB
Largest eagerly-shipped chunks
Size File
1000.6 KiB dist/toolbar/toolbar-app-UNV2DLO6.css
492.1 KiB dist/toolbar/chunk-chunk-MVSKU5QP.js
286.3 KiB dist/toolbar/chunk-chunk-LF6OQN2J.js
219.1 KiB dist/toolbar/chunk-chunk-TVMGHSZ2.js
137.5 KiB dist/toolbar/chunk-chunk-HFV5BNCK.js
131.8 KiB dist/toolbar/chunk-chunk-FDH2IBXT.js
75.7 KiB dist/toolbar/toolbar-app-KHDNXVQA.js
69.0 KiB dist/toolbar/chunk-chunk-TSAL54PB.js
35.8 KiB dist/toolbar/chunk-chunk-KTLELJMT.js
33.8 KiB dist/toolbar/chunk-chunk-P3OXELHV.js

Posted automatically by check-toolbar-size · sizes are toolbar output bytes (shipped, post-tree-shake) from the esbuild metafile

✅ Dist folder size — 🔺 +447.1 KiB (+0.0%)

Total size of the built frontend/dist folder (all assets), compared against the base branch.

Total: 1038.94 MiB · 🔺 +447.1 KiB (+0.0%)

ℹ️ MCP UI apps size — 35 app(s), 37026.9 KB JS

Built size of each MCP UI app (main.js + styles.css).

App JS CSS
debug 1067.4 KB 225.3 KB
explain-chart 1353.6 KB 225.3 KB
action 994.8 KB 225.3 KB
action-list 1058.5 KB 225.3 KB
cohort 993.8 KB 225.3 KB
cohort-list 1057.5 KB 225.3 KB
email-template 993.6 KB 225.3 KB
error-details 998.7 KB 225.3 KB
error-issue 995.7 KB 225.3 KB
error-issue-list 1059.7 KB 225.3 KB
experiment 1055.6 KB 225.3 KB
experiment-list 1059.3 KB 225.3 KB
experiment-results 1057.7 KB 225.3 KB
feature-flag 1057.9 KB 225.3 KB
feature-flag-list 1061.6 KB 225.3 KB
feature-flag-testing 997.0 KB 225.3 KB
inline-scan 994.3 KB 225.3 KB
insight-actors 1057.0 KB 225.3 KB
llm-costs 1054.3 KB 225.3 KB
session-recording 996.0 KB 225.3 KB
survey 995.4 KB 225.3 KB
survey-global-stats 1054.3 KB 225.3 KB
survey-list 1059.2 KB 225.3 KB
survey-stats 1054.3 KB 225.3 KB
trace-span 994.2 KB 225.3 KB
trace-span-list 1058.8 KB 225.3 KB
vision-observation-list 1057.6 KB 225.3 KB
workflow 994.1 KB 225.3 KB
workflow-list 1057.9 KB 225.3 KB
workflow-setup-status 993.8 KB 225.3 KB
query-results 1323.0 KB 225.3 KB
render-ui 1430.0 KB 225.3 KB
visual-review-snapshots 998.7 KB 225.3 KB
workflow-data-suggestions 996.5 KB 225.3 KB
workflow-sending-rules 995.1 KB 225.3 KB
ℹ️ MCP agent API — agent-facing tool changes

What this PR changes for agents, from the tool schema snapshots and tool definitions.

Tools changed (1):

Tool Params Scopes Annotations Schema chars
generate-app-url 11,312 -> 11,324
⚠️ Playwright — 2 flaky

🎭 Playwright report · View test results →

⚠️ 2 flaky tests:

  • Delete a person property (chromium)
  • a secret header entered in the workflow builder is stored encrypted and read back masked (chromium)

These issues are not necessarily caused by your changes.
Annoyed by this section? Help fix flakies and failures and it will go green!

⚠️ Backend snapshots — 1 updated (1 modified, 0 added, 0 deleted)

Query snapshots: Backend query snapshots updated

Changes: 1 snapshots (1 modified, 0 added, 0 deleted)

What this means:

  • Query snapshots have been automatically updated to match current output
  • These changes reflect modifications to database queries or schema

Next steps:

  • Review the query changes to ensure they're intentional
  • If unexpected, investigate what caused the query to change

Review snapshot changes →

⚠️ MCP snapshots — 1 updated (1 modified, 0 added, 0 deleted)

Snapshots: MCP unit test snapshots updated

Changes: 1 snapshots (1 modified, 0 added, 0 deleted)

What this means:

  • Snapshots have been automatically updated to match current output

Next steps:

  • Review the changes to ensure they're intentional
  • If unexpected, investigate what caused the output to change

Review snapshot changes →

✅ Hogbox preview — ready, open the preview

▶ Open the preview

🔑 Login test@posthog.com / 12345678 (demo data)
🧩 Running this PR's backend and frontend, on the PostHog :master base
🔗 Link stable across rebuilds: a re-push swaps the box underneath, the URL stays
🔒 Access tailnet only (PostHog VPN)
🛠️ Admin inspect & debug state in hogland
💤 Idle sleeps after ~30 min idle (snapshot to S3, zero node cost) and wakes on your next visit in ~30s, behind a brief "waking up" screen

commit df4184a · box box-021e2db09432 · ready in 1578s (push → usable) · build log · rebuilds on every push, torn down on close

@EDsCODE
EDsCODE marked this pull request as ready for review October 7, 2026 13:30
@parameterai

parameterai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Risk: No findings

This delta since the last review is a mechanical refactor: the Warehouse home components (getting-started step, health issue row, recent run row, shared status-badge helper) were extracted into their own files with identical JSX bodies. No new routes, data flows, access checks, or exposure; the only externally-sourced link target (issue.url) is built server-side from static relative path templates and is unchanged from the previously reviewed code. No security findings.

Sentinel reviewed da446de · Review settings

@bill-ph bill-ph left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the PR description and the full diff. Read the surrounding code where needed: todayShellLogic (pane and sidebar selectors, listeners), TodayTabBar, SceneTabs/todaySceneTabsLogic (portal and hold timer), the Navigation.tsx wrapper restructure, the LemonTabs.barHidden change, toolsLogic's Products exclusion, the 9 scene swaps (including SourceScene's two mutually exclusive SceneTabs), and the warehouse home logic and components.

For flag-off users, the Navigation.tsx change looks layout-neutral. The new wrapper is the only flex child of the same row container, it carries relative for the absolutely positioned takeover and scene panel, and the @container/main-content-container queries still resolve against the outer element. barHidden only skips the <ul> and leaves content rendering unchanged. The home page is gated on both flags before its logic mounts, so flag-off users trigger no API calls.

P1

  • Phone tab bar shows the Warehouse tab without the flag. frontend/src/layout/today/TodayTabBar.tsx iterates TODAY_RAIL_ITEMS directly and isn't updated in this PR. Only TodayRail filters with withoutWarehouse. Every phone user on today-rail-nav alone gets a Warehouse tab that leads to a NotFound page. Filter it the same way (or expose filtered items from todayShellLogic) and add a flag-off test.

P2

  • Sidebar tabs can disappear when routePane and activePane disagree. sceneTabsInSidebar checks routePane === 'warehouse', but the portal target only exists when activePane === 'warehouse'. pickedPane is stamped by locationChanged with the flag value at that moment. A navigation or URL replace before flags load (e.g. /models → /models?tab=… on a cold load) leaves pickedPane = 'products', and after flags load the tab bar is in neither place. Adding activePane === 'warehouse' to the selector closes this.
  • The saved-query count is heavier than needed. loadSavedQueryCount fetches a full page of saved queries with columns (include_columns defaults to true) just to read .count. Pass include_columns: false. It's also missing from ERROR_FILTER_ALLOW_LIST, so a failure still toasts even though the step quietly degrades to 'todo'.

Inline comments

  • frontend/src/layout/today/todayRailItems.tsx:16 — P1: TodayTabBar.tsx (the phone bottom bar) still maps over the unfiltered TODAY_RAIL_ITEMS. Only TodayRail goes through withoutWarehouse. So every phone user on today-rail-nav, with today-rail-warehouse off, now gets a Warehouse tab. Tapping it calls pickPane('warehouse'), which pushes /warehouse, and WarehouseHomeScene renders NotFound. activePane then falls back to Home, so the tab never even highlights. This breaks the PR's claim that the rail behaves as on master with only today-rail-nav on. Fix: filter TodayTabBar with withoutWarehouse(TODAY_RAIL_ITEMS, todayWarehouseEnabled). Better, export a filtered selector from todayShellLogic so a third consumer can't miss it. A test on the tab bar items for the flag-off case would also help.
  • frontend/src/layout/today/todayShellLogic.ts:372 — P2: sceneTabsInSidebar keys off routePane, but the sidebar that hosts the portal renders for activePane. These can disagree. pickedPane is written by the locationChanged listener using the warehouse flag value at that moment. Suppose a navigation or URL replace happens before flags load, e.g. /models getting ?tab= added on a cold load. Then pickedPane becomes 'products'. When flags arrive, routePane is 'warehouse' but activePane stays 'products'. SceneTabs hides the in-page bar, and tabsElement is null because the Products pane is showing. The tabs then vanish completely, which is the case the PR says can't happen. Adding activePane === 'warehouse' here (or requiring activePaneHasSidebar) makes it safe. It doesn't create a cycle, since sceneTabsMounted comes from routePane.
  • products/data_warehouse/frontend/scenes/WarehouseHomeScene/warehouseHomeLogic.ts:125 — P2: warehouseSavedQueriesList defaults to include_columns=true and returns a full page of saved queries with their column definitions, just to read .count. Pass { include_columns: false } to keep this cheap for teams with many views. Also, loadSavedQueryCount isn't on the ERROR_FILTER_ALLOW_LIST like the other two loaders. A failure still pops a global toast even though the step degrades to 'todo' quietly.

— Robo Bill v2 (opus, high reasoning)

@greptile-apps

greptile-apps Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Retrigger

[Medium risk] Adds warehouse navigation pane to the rail layout.

Fix the full health-list fallback and satisfy the frontend requirements before merging.

Reviews (1) · Last reviewed commit: "feat(data-warehouse): add a warehouse ar..." · Reviewed by Greptile

@trunk-io

trunk-io Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Static Badge   Static Badge   Static Badge

Failed Test Failure Summary Logs
Scenes-App/Experiments ExperimentWithHealthFindings play-test The Storybook test could not find the text “Why?” in the rendered page. Logs ↗︎
Scenes-App/People/Person PersonNotFound smoke-test The test timed out while waiting for loading indicators or spinners to disappear. Logs ↗︎
ReportContextMenu routes the dismiss submenu's note button through the dialog instead of applying it The test expected an element to be present in the document, but it could not be found. Logs ↗︎
DiscussReportButton shows multiple report suggestions in the current suggestions menu The test could not find the report’s Ask AI suggestion element with data-attr="inbox-report-ask-ai-suggestion". Logs ↗︎

View Full Report ↗︎ ⋅ Docs

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@github-actions
github-actions Bot requested a deployment to preview-pr-113361 October 7, 2026 13:54 In progress
EDsCODE and others added 2 commits October 7, 2026 16:14
Endpoints serves insights and queries over HTTP, so it is not a warehouse
tool. It leaves the Warehouse menu and its pages keep the in-page tab bar.

The phone tab bar now hides the Warehouse tab unless today-rail-warehouse
is on, matching the desktop rail.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…e-rail

# Conflicts:
#	services/mcp/tests/unit/__snapshots__/tool-schemas/generate-app-url.json
@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: PostHog/posthog/.coderabbit.yaml
  • Review profile: QUIET
  • Plan: Enterprise
  • Run ID: 707bfca0-90ca-4fce-865b-b2ec1aac036e
📥 Commits

Reviewing files that changed from the base of the PR and between 95bd67d and dc39110.

📒 Files selected for processing (4)
  • frontend/src/layout/navigation-3000/Navigation.tsx
  • frontend/src/layout/scenes/components/QuillSceneTitleSection.tsx
  • frontend/src/layout/today/TodayWarehouseHeader.tsx
  • frontend/src/layout/today/todayShellLogic.ts

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 10 remain after this review.

📝 Walkthrough

Adds a feature-flagged Warehouse route and Today layout, including a warehouse header and sidebar navigation. Existing scene tabs can render in the sidebar. The new Warehouse home displays setup steps, health issues, and recent runs.

Priority: ➖ Normal

Merge Risk: 🔵 Low · up to dc391

The feature remains behind flags, but known Warehouse UI issues remain. Resolve or explicitly accept them before enabling it for users.

Security architecture risk: 🔵 Low · up to dc391

The change primarily reorganizes warehouse navigation and presents existing project data. The inspected paths preserve project scoping and access checks, with no demonstrated expansion of permissions. Some transition behavior and authorization coverage remain incompletely verified.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

  • inferred — The inspected new data-display path is scoped to the active project’s pipeline and saved-view metadata. It adds a home-page caller to existing APIs, but no new credential, service identity or elevated execution authority was demonstrated in that path.

Trust Boundaries and Controls

  • observed — Warehouse menu visibility uses effective product access and per-item feature flags. Direct scene navigation also retains project-denial handling. These client controls remain distinct from the server permission chain; the complete WarehouseHome resource mapping was not resolved.

Resilience and Maintainability Implications

  • inferred — The pre-existing AI registry replaces and deletes registrations solely by identifier, and pending calls resolve handlers from the current map. This is an ownership limitation, but the PR moves the previous scene-supplied registration rather than demonstrating broader authority or a newly reachable cross-project attack. Interrupted handoff ordering remains unverified.

Hardening Proposals

  • proposed — As follow-up hardening of the existing AI registry, bind registrations and pending dispatch to an owner or scene/project generation, and make cleanup conditional on matching ownership. This would strengthen transition isolation; it is not an observed vulnerability introduced by this PR.
Pre-merge checks: Passed 1
Check name Status Explanation
Description check Passed The pull request description is complete and follows the repository template. It explains the problem, user-visible changes, feature-flag release status, testing scope and rationale, documentation imp…
Full details: Description check

Explanation

The pull request description is complete and follows the repository template. It explains the problem, user-visible changes, feature-flag release status, testing scope and rationale, documentation impact, agent context, design decisions, and known validation gaps. Screenshots are included for the frontend changes.

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

Quiet mode is enabled, so only the most important comments were posted inline. Other review comments are grouped below.

🟡 Other comments (2)
products/data_warehouse/frontend/scenes/WarehouseHomeScene/warehouseHomeLogic.ts (1)

159-159: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Add loadSavedQueryCount to the error allow list or handle its failure.

viewStep treats a failed saved-query count as todo, so the page already handles this failure. initKea.ts allow-lists only the health and runs loaders. If warehouseSavedQueriesList fails, the user sees a generic error toast and an unfinished step. Add 'loadSavedQueryCount' to ERROR_FILTER_ALLOW_LIST with a comment, or rename the loader to a warehouse-specific action name and allow-list that name. The generic name loadSavedQueryCount may also match unrelated loaders in the global list.

frontend/src/layout/scenes/components/SceneTabs.tsx (1)

25-43: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Do not hide the bar when the portal target is missing.

If sceneTabsInSidebar is true and tabsElement is null, the component renders no tab bar anywhere. tabsElement is null until TodayWarehouseTabsPane mounts, and it is null whenever another pane is active. Fall back to the in-page bar in that case.

Proposed fix
-    if (!sceneTabsInSidebar) {
+    if (!sceneTabsInSidebar || !tabsElement) {
         return <LemonTabs {...props} />
     }

ℹ️ Review info
⚙️ Run configuration
  • Configuration used: Repository: PostHog/posthog/.coderabbit.yaml
  • Review profile: QUIET
  • Plan: Enterprise
  • Run ID: 05c323d4-2767-4f49-ad70-f5c917d78b4a
📥 Commits

Reviewing files that changed from the base of the PR and between 9b69890 and 058cad7.

📒 Files selected for processing (43)
  • frontend/src/initKea.ts
  • frontend/src/layout/navigation-3000/Navigation.tsx
  • frontend/src/layout/scenes/components/SceneTabs.tsx
  • frontend/src/layout/today/TodayRail.tsx
  • frontend/src/layout/today/TodaySceneTabsList.test.tsx
  • frontend/src/layout/today/TodaySceneTabsList.tsx
  • frontend/src/layout/today/TodayShell.tsx
  • frontend/src/layout/today/TodayTabBar.tsx
  • frontend/src/layout/today/TodayWarehouseHeader.stories.tsx
  • frontend/src/layout/today/TodayWarehouseHeader.tsx
  • frontend/src/layout/today/TodayWarehouseTabsPane.tsx
  • frontend/src/layout/today/todayRailItems.tsx
  • frontend/src/layout/today/todaySceneTabsLogic.test.ts
  • frontend/src/layout/today/todaySceneTabsLogic.ts
  • frontend/src/layout/today/todayShellLogic.test.ts
  • frontend/src/layout/today/todayShellLogic.ts
  • frontend/src/layout/today/todayViewsLogic.ts
  • frontend/src/layout/today/todayWarehouseItems.test.ts
  • frontend/src/layout/today/todayWarehouseItems.ts
  • frontend/src/lib/constants.tsx
  • frontend/src/lib/lemon-ui/LemonTabs/LemonTabs.tsx
  • frontend/src/productScenes.tsx
  • frontend/src/products.tsx
  • frontend/src/scenes/sceneTypes.ts
  • frontend/src/scenes/tools/toolsLogic.test.ts
  • frontend/src/scenes/tools/toolsLogic.ts
  • products/data_catalog/frontend/DataCatalogMetricScene.tsx
  • products/data_catalog/frontend/DataCatalogScene.tsx
  • products/data_modeling/frontend/ModelsScene.tsx
  • products/data_modeling/frontend/nodeDetail/NodeDetailScene.tsx
  • products/data_warehouse/frontend/scenes/DataOpsScene/DataWarehouseScene.tsx
  • products/data_warehouse/frontend/scenes/SchemaScene/SchemaScene.tsx
  • products/data_warehouse/frontend/scenes/SourceScene/SourceScene.tsx
  • products/data_warehouse/frontend/scenes/WarehouseHomeScene/WarehouseGettingStarted.tsx
  • products/data_warehouse/frontend/scenes/WarehouseHomeScene/WarehouseHealth.tsx
  • products/data_warehouse/frontend/scenes/WarehouseHomeScene/WarehouseHomeScene.stories.tsx
  • products/data_warehouse/frontend/scenes/WarehouseHomeScene/WarehouseHomeScene.tsx
  • products/data_warehouse/frontend/scenes/WarehouseHomeScene/WarehouseRecentRuns.tsx
  • products/data_warehouse/frontend/scenes/WarehouseHomeScene/warehouseHomeLogic.test.ts
  • products/data_warehouse/frontend/scenes/WarehouseHomeScene/warehouseHomeLogic.ts
  • products/data_warehouse/manifest.tsx
  • services/mcp/src/tools/links/app-url-manifest.json
  • services/mcp/tests/unit/__snapshots__/tool-schemas/generate-app-url.json

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

Notebooks leaves the Warehouse menu and the home page drops its explore
step, so getting started is connect a source, then create a view.
Notebooks stays in the Views pane.

Every remaining menu item owns its route, so the ownsRoute flag goes too.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

Quiet mode is enabled, so only the most important comments were posted inline. Other review comments are grouped below.

🟡 Other comments (1)
products/data_warehouse/frontend/scenes/WarehouseHomeScene/WarehouseGettingStarted.tsx (1)

24-24: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Add the Explore your data step.

WarehouseStep permits only two steps, and this component renders only those two rows. The specified Warehouse home checklist includes a third step with notebook and BI actions. Add its step identifier and row so users can reach those actions from the checklist. As per path instructions, the code must “express every idea it needs to express.”

Source: Path instructions


ℹ️ Review info
⚙️ Run configuration
  • Configuration used: Repository: PostHog/posthog/.coderabbit.yaml
  • Review profile: QUIET
  • Plan: Enterprise
  • Run ID: 27aa64a9-22eb-4032-8a38-1f1fb9f8877f
📥 Commits

Reviewing files that changed from the base of the PR and between 058cad7 and 9772348.

📒 Files selected for processing (4)
  • frontend/src/layout/today/todayWarehouseItems.test.ts
  • frontend/src/layout/today/todayWarehouseItems.ts
  • products/data_warehouse/frontend/scenes/WarehouseHomeScene/WarehouseGettingStarted.tsx
  • products/data_warehouse/frontend/scenes/WarehouseHomeScene/WarehouseHomeScene.stories.tsx
💤 Files with no reviewable changes (2)
  • frontend/src/layout/today/todayWarehouseItems.test.ts
  • products/data_warehouse/frontend/scenes/WarehouseHomeScene/WarehouseHomeScene.stories.tsx

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 10 remain after this review.

EDsCODE and others added 3 commits October 7, 2026 17:13
…eader

On desktop the warehouse tabs sidebar now sits under the warehouse
header, beside the page, instead of as a full-height column next to the
rail. The content column becomes a grid under the rail navigation, so
the header spans the sidebar and the page.

The rail carries the account menu while the warehouse sidebar is in the
content column. The narrow-window drawer and the phone layout are
unchanged.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The warehouse header already names each top-level warehouse page, so
those pages drop their own title and description. Their actions now sit
in a row directly above the page content. Nested pages, like one source
or one model, keep their title because the header does not show the
resource name.

The current warehouse page now comes from one selector, which the
header, the sidebar title and the scene title share.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The scene title now depends on the route, so the story opens /warehouse
to match what the app shows there.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

@posthog posthog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PostHog Review · Standard · reviewed 314491b: 5 Should fix. This pull request is large, so the review ran in 4 parts with less depth than usual.

Comment on lines +208 to +212
afterMount(({ actions }) => {
actions.loadSavedQueryCount()
actions.loadWarehouseHomeHealthIssues()
actions.loadWarehouseHomeRecentRuns()
}),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 · Refresh health and activity while the overview remains open

When a sync fails or finishes after the home page loads, afterMount never refreshes health or activity. The page continues showing “All clear” or “Running” indefinitely, and successful sections expose no refresh control. This leaves the monitoring surface reporting obsolete pipeline status; add visibility-aware polling with cleanup or an explicit refresh control.

@posthog posthog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PostHog Review · Standard · reviewed 00a6a55: no findings. This pull request is large, so the review ran in 4 parts with less depth than usual.

EDsCODE and others added 3 commits October 22, 2026 15:59
Resolve conflicts with the lazy Today layout and rail pane homes on master:
- Navigation lazy-loads the warehouse header and sidebar like the other
  Today components, so their quill UI stays off the logged-in shell.
- The main scroller drops rounded-t and rounded-r-none, as on master; the
  warehouse grid wrapper around it stays.
- The warehouse pane home moves into RAIL_PANE_HOMES, and the shell logic
  no longer imports todayRailItems.
- TodayShell keeps the analytics preview-card provider and the warehouse pane.
- Regenerate the generate-app-url snapshot from the merged manifest.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@EDsCODE

EDsCODE commented Oct 27, 2026

Copy link
Copy Markdown
Collaborator Author

/depot retry

@scheduled-actions-posthog

Copy link
Copy Markdown
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, please remove the stale label – otherwise this will be closed in another week. If you want to permanently keep it open, use the waiting label.

@scheduled-actions-posthog

Copy link
Copy Markdown
Contributor

This PR was closed due to lack of activity. Feel free to reopen if it's still relevant.

EDsCODE and others added 3 commits November 19, 2026 10:55
Resolve conflicts with master's Today shell rework and adapt the
warehouse pane to it:

- Register the warehouse pane in TODAY_PANE_FLAGS and TODAY_RAIL_PANES,
  so master's railPanes and activePane fallback gate it. This drops the
  PR's own withoutWarehouse helper and rememberRoutePane action.
- Port the warehouse header, in-content sidebar and content grid from
  Navigation.tsx into the new TodayFramedLayout and TodayPhoneLayout,
  through an opt-in grid mode on MainContentColumn.
- Add the warehouse sidebar to TodayShell's PANE_SIDEBARS and leave it
  out of the pane intros, because its sidebar holds the page's own tabs.
- Follow master's removals: the sql-editor-bi-mode flag and quill's
  elevated button prop.
- List the other Definitions tab URLs in the warehouse items instead of
  importing a scene logic into the shell layer, with a test that fails
  when a tab is missing, and import sidebar.scss where .TodayPane is used.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Master's frontend-layers check rejects the static import of
scenes/max/useMaxTool from the shell-layer QuillSceneTitleSection.
A small MaxToolRegistration component next to the hook now calls it,
and the title section loads that component with lazyWithRetry while
the warehouse header shows. The SQL editor keeps its execute_sql tool
on warehouse pages.

Both return branches of the title section render the registration
first, so switching between them does not deregister the tool.

Also type the Definitions drift rows in todayWarehouseItems.test.ts as
tuples, which typecheck requires.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Master's test-owners check fails a branch that adds a test file with no
team owner. Give the warehouse rail pane's files in layout/today to
team-managed-warehouse, which owns the data_warehouse product, and the
Today rail's Tools scene to team-surfaces, which owns the Today product.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@veria-ai

veria-ai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Reviews

@posthog posthog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PostHog Review · Standard · reviewed edda304: 1 Should fix. This pull request is large, so the review ran in 4 parts with less depth than usual.

Comment on lines +111 to +115
return (
<>
{maxToolRegistration}
<div data-quill className={cn('flex flex-wrap items-center justify-end gap-1 empty:hidden', className)}>
{actions}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 · Preserve saved-view titles and edit status in the SQL editor

With both flags enabled, opening /sql?open_view=… produces two breadcrumbs, so this branch hides the saved view's name and its Edited status. SQLEditor supplies these through name and nameSuffix, while the warehouse header only names “SQL editor”. Preserve the resource title and status when editing a saved view instead of treating it as a top-level page.

EDsCODE and others added 3 commits November 19, 2026 15:54
Keep both rule sets in layout/today/owners.yaml: master added rules for
the task chips, and this branch adds the warehouse pane files. Keep the
/warehouse route in the generate-app-url schema snapshot.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…trino

- Move scene tabs into the warehouse sidebar only while the warehouse
  pane is the active pane. Picking another pane on a warehouse page
  unmounts that sidebar, so the tabs now stay in the page.
- Render LemonTabs at the same position in SceneTabs whether or not the
  bar is in the sidebar, so a toggle keeps the tab content mounted.
- List Data ops in the warehouse menu for teams with only
  managed-trino-query, as the product manifest does.
- Ask the saved-query list for no column definitions when the warehouse
  home only needs the count.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Move the health issue row, the recent run row and the getting started
step into their own files, as the frontend guide asks for components
with their own logic. The status badge helper that the health card and
its rows share moves to warehouseHealthStatus.ts.

Render the changing counts and labels as sole text nodes or in their
own elements, so page translation cannot leave them stale.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@posthog

posthog Bot commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

👋 Visual changes detected for this PR.

Review and approve in PostHog Visual Review

If these changes are unexpected, they may be caused by a flaky test or a broken snapshot on master. Don't approve — rerun the job or wait for a fix.

Install the Visual Review Chrome extension to see visual review results at the top of your pull requests.

This branch was successfully deployed

2 active (outdated) deployments
hogbox-preview — df4184ac Deployed Oct 19, 2026 by github-actions[bot]
preview-pr-113361 — 176c496f Deployed Oct 8, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-inkeep-docs Use this label to skip an Inkeep docs PR in posthog.com stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants