Repository navigation
feat(signals): add a scout that watches the organization's own bill #137999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+567
−1
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The shipped
signals-scout-billingskill (inproducts/signals/skills/signals-scout-billing/) reads the organization's bill under an acting user withbilling:read, then publishes dollar deltas, spending-limit proximity, and trial-end warnings into inbox reports, the scratchpad, and Slack — surfaces gated only by team membership (ScoutCanonicalTeamAccessPermission,products/signals/backend/presentation/scout_permissions.py:13), never by billing access. The skill's own text admits it: "anyone who can read the inbox reads your billing numbers whether or not the billing pages would let them in" (SKILL.md:257). The sole control is LLM instruction-following ("carry only the dollar delta", SKILL.md:258; "memory holds volumes, dates, and verdicts, never billing detail", SKILL.md:240), and the PR lists "gate report visibility by billing access in code" as an undone follow-up — so an org admin's billing read is summarized into team- and Slack-visible facts for members the billing pages deny.How:
Fix: gate this scout's report/scratchpad reads (or its emission content) on billing access in code, as the PR's own follow-up already plans.
React with 👍 if useful or 👎 if not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Valid, and accepted for now rather than fixed here. The scout registers disabled on every project, so a person with billing access has to turn it on before any report exists. The code gate on report and memory reads is the follow-up before it is enabled by default. 72628f5 also removes the two calls that could read other projects' usage.