Repository navigation
Conversation
Assisted-by: OpenAI Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A request such as
Range: bytes=-100for a four-byte representation currently produces a 416 response. RFC 9110 section 14.1.2 specifies that a suffix longer than the selected representation selects the entire representation.Clamp the resolved suffix start to zero for non-empty representations. Update the existing contradictory unsatisfiable assertion, cover suffix lengths equal to and larger than the representation, and test a complete conditional response including its status, Content-Range, Content-Length and body. Add an unreleased changelog entry.
Specification: https://www.rfc-editor.org/rfc/rfc9110.html#section-14.1.2
Validation:
git diff --checkpasses.AI assistance: this patch and its tests were developed with OpenAI Codex.
Existing behavior for empty representations and zero-length suffixes is outside this fix.