Skip to content

setting remoteDpc to getIncomingOpc() instead of getIncomingDpc() #353

Description

@sgurivir

RepoIQ (http://repoiq.ai) has identified a potential logical issue in SccpConnectionBaseImpl.java

Potential issue in receiveMessage in sccp/sccp-impl/src/main/java/org/restcomm/protocols/ss7/sccp/impl/SccpConnectionBaseImpl.java

https://github.com/RestComm/jss7/blob/master/sccp/sccp-impl/src/main/java/org/restcomm/protocols/ss7/sccp/impl/SccpConnectionBaseImpl.java#L94

Logic error: setting remoteDpc to getIncomingOpc() instead of getIncomingDpc()

Impact: Incorrect remote destination point code assignment which could cause message routing failures in SS7 communication

Potential Solution: Change line 94 to: remoteDpc = cc.getIncomingDpc();

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions