Skip to content

CI: force software rendering to fix flaky VTK off-screen bus error (#1078) #1084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wuisabel-gif wants to merge 4 commits into
base: develop
Choose a base branch
from
+58 −2
Open

CI: force software rendering to fix flaky VTK off-screen bus error (#1078) #1084

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
65d0a61
CI: force Mesa software rendering to fix flaky VTK off-screen bus err…
wuisabel-gif Jul 22, 2026
15968a8
Fix platform-specific VTK CI rendering
wuisabel-gif Jul 29, 2026
4d988a5
Merge branch 'develop' into ci/software-render-animation-tests
wuisabel-gif Jul 30, 2026
a22b95d
Isolate flaky VTK animation tests
wuisabel-gif Aug 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 27 additions & 1 deletion .github/workflows/test-pytest-slow.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ jobs:
env:
PYTHON: ${{ matrix.python-version }}
MPLBACKEND: Agg
LIBGL_ALWAYS_SOFTWARE: "1"
GALLIUM_DRIVER: llvmpipe
steps:
- uses: actions/checkout@main
- name: Set up headless display
Expand Down Expand Up @@ -52,7 +54,31 @@ jobs:
run: pytest rocketpy --doctest-modules --cov=rocketpy --cov-append

- name: Run Integration Tests
run: pytest tests/integration --cov=rocketpy --cov-append
run: |
pytest tests/integration \
--deselect tests/integration/test_plots.py::test_flight_animations_run_off_screen \
--deselect tests/integration/test_plots.py::test_flight_animations_render_all_scene_options \
--deselect tests/integration/test_plots.py::test_flight_animation_export_gif \
--cov=rocketpy --cov-append

- name: Run VTK animation tests
run: |
tests=(
tests/integration/test_plots.py::test_flight_animations_run_off_screen
tests/integration/test_plots.py::test_flight_animations_render_all_scene_options
tests/integration/test_plots.py::test_flight_animation_export_gif
)
attempts=3
for attempt in $(seq 1 "$attempts"); do
if pytest "${tests[@]}" --cov=rocketpy --cov-append; then
exit 0
else
status=$?
fi
if [[ "$status" != "138" || "$attempt" == "$attempts" ]]; then
exit "$status"
fi
done

- name: Run Acceptance Tests
run: pytest tests/acceptance --cov=rocketpy --cov-append --cov-report=xml
Expand Down
32 changes: 31 additions & 1 deletion .github/workflows/test_pytest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ jobs:
Pytest:
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
python-version: ["3.10", "3.14"]
Expand All @@ -28,6 +29,11 @@ jobs:
- uses: actions/checkout@main
- name: Set up headless display
uses: pyvista/setup-headless-display-action@v4
- name: Configure Mesa software rendering on Linux
if: runner.os == 'Linux'
run: |
echo "LIBGL_ALWAYS_SOFTWARE=1" >> "$GITHUB_ENV"
echo "GALLIUM_DRIVER=llvmpipe" >> "$GITHUB_ENV"
- name: Set up Python
uses: actions/setup-python@main
with:
Expand Down Expand Up @@ -58,7 +64,31 @@ jobs:
pytest rocketpy --doctest-modules --cov=rocketpy --cov-append

- name: Run Integration Tests
run: pytest tests/integration --cov=rocketpy --cov-append
run: |
pytest tests/integration \
--deselect tests/integration/test_plots.py::test_flight_animations_run_off_screen \
--deselect tests/integration/test_plots.py::test_flight_animations_render_all_scene_options \
--deselect tests/integration/test_plots.py::test_flight_animation_export_gif \
--cov=rocketpy --cov-append

- name: Run VTK animation tests
run: |
tests=(
tests/integration/test_plots.py::test_flight_animations_run_off_screen
tests/integration/test_plots.py::test_flight_animations_render_all_scene_options
tests/integration/test_plots.py::test_flight_animation_export_gif
)
attempts=3
for attempt in $(seq 1 "$attempts"); do
if pytest "${tests[@]}" --cov=rocketpy --cov-append; then
exit 0
else
status=$?
fi
if [[ "$status" != "138" || "$attempt" == "$attempts" ]]; then
exit "$status"
fi
done

- name: Run Acceptance Tests
run: pytest tests/acceptance --cov=rocketpy --cov-append --cov-report=xml
Expand Down