Skip to content

Pin shell in installer-generated env setup - #1525

Merged
Schniz merged 3 commits into
masterfrom
schniz/365-explicit-shell-install-default
Mar 9, 2026
Merged

Schniz merged 3 commits into
masterfrom
schniz/365-explicit-shell-install-default

Conversation

@Schniz

@Schniz Schniz commented Mar 9, 2026

Copy link
Copy Markdown
Owner

Summary

  • Update .ci/install.sh to write explicit shell flags in generated shell init snippets (--shell bash|zsh|fish) instead of relying on runtime shell inference.
  • Keep runtime shell inference in fnm env/fnm completions unchanged for backwards compatibility, while nudging users toward explicit shell usage.
  • Update user-facing docs (README.md and generated docs/commands.md) so examples prefer explicit shell selection and mention the small performance benefit.

Closes #365

@vercel

vercel Bot commented Mar 9, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fnm Ready Ready Preview, Comment Mar 9, 2026 7:37pm

@changeset-bot

changeset-bot Bot commented Mar 9, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 97e1e3a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
fnm Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Schniz
Schniz merged commit bfb1860 into master Mar 9, 2026
28 checks passed
@Schniz
Schniz deleted the schniz/365-explicit-shell-install-default branch March 9, 2026 19:53
Schniz added a commit that referenced this pull request Mar 10, 2026
* perf(install): pin shell in generated env setup

* ci: pin docker platform for ARM installer tests

* chore: add changeset for installer shell update
Dargon789 pushed a commit to Dargon789/fnm that referenced this pull request Mar 13, 2026
* perf(install): pin shell in generated env setup

* ci: pin docker platform for ARM installer tests

* chore: add changeset for installer shell update
Dargon789 pushed a commit to Dargon789/fnm that referenced this pull request Mar 13, 2026
* perf(install): pin shell in generated env setup

* ci: pin docker platform for ARM installer tests

* chore: add changeset for installer shell update

This branch was successfully deployed

1 active deployment
Preview — 97e1e3ad Deployed Mar 9, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate shell inference

1 participant