Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ jobs:
with:
version: nightly

- run: yarn install --network-concurrency 1
- run: yarn install --frozen-lockfile --network-concurrency 1

- name: Run tests
run: yarn test
Expand All @@ -75,7 +75,7 @@ jobs:
with:
version: nightly

- run: yarn install
- run: yarn install --frozen-lockfile

- name: Run coverage
run: yarn coverage
Expand Down Expand Up @@ -142,7 +142,7 @@ jobs:
urlTemplate: https://github.com/ScopeLift/scopelint/releases/download/{{version}}/scopelint-x86_64-linux.tar.xz
token: ${{ secrets.GITHUB_TOKEN }}

- run: yarn install
- run: yarn install --frozen-lockfile

- name: Run yarn lint
run: yarn lint
Expand Down
5 changes: 2 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -122,14 +122,13 @@ yarn test # runs tests for each of the 3 packages
yarn dev:netlify # runs the frontend through Netlify Dev with local Functions
```

For frontend development that needs receive scanning to work locally, install the Netlify CLI and use Netlify Dev from the workspace root:
For frontend development that needs receive scanning to work locally, use the project-local Netlify CLI installed by `yarn install`. Run Netlify Dev from the workspace root; the script automatically selects the frontend workspace:

```sh
npm install -g netlify-cli # one-time install if netlify is not already on your PATH
yarn dev:netlify
```

Open `http://localhost:8888`, not Quasar's direct `http://localhost:8080` URL. Netlify Dev serves the frontend and the `/api/ponder` Function from the same local origin, which matches deployed scan behavior. If you want Netlify Dev to pull environment variables from a hosted Netlify site, run `netlify login` and link this checkout to the Umbra app/frontend site; otherwise, the local workspace root `.env` values below are enough.
Open `http://localhost:8888`, not Quasar's direct `http://localhost:8080` URL. Netlify Dev serves the frontend and the `/api/ponder` Function from the same local origin, which matches deployed scan behavior. If you want Netlify Dev to pull environment variables from a hosted Netlify site, run `yarn netlify login` and `yarn netlify link --filter @umbra/frontend` to link this checkout to the Umbra app/frontend site; otherwise, the local workspace root `.env` values below are enough.

Set `PONDER_SUBGRAPH_URL=/api/ponder` in `frontend/.env`. Set the private Function runtime variables in the workspace root `.env` or in the linked Netlify site environment:

Expand Down
5 changes: 2 additions & 3 deletions frontend/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,13 @@ Install dependencies from the workspace root:
yarn install
```

For local frontend development with receive scanning enabled, install the Netlify CLI and run the app through Netlify Dev from the workspace root:
For local frontend development with receive scanning enabled, use the project-local Netlify CLI installed by `yarn install`. Run Netlify Dev from the workspace root; the script automatically selects the frontend workspace:

```bash
npm install -g netlify-cli # one-time install if netlify is not already on your PATH
yarn dev:netlify
```

Open `http://localhost:8888`. Quasar also runs on `http://localhost:8080`, but that direct URL bypasses the Netlify Function proxy and should not be used to test receive scans. Run `netlify login` and link the checkout to the Umbra app/frontend site if you want Netlify Dev to pull hosted site environment variables; local workspace root `.env` values also work.
Open `http://localhost:8888`. Quasar also runs on `http://localhost:8080`, but that direct URL bypasses the Netlify Function proxy and should not be used to test receive scans. Run `yarn netlify login` and `yarn netlify link --filter @umbra/frontend` to link the checkout to the Umbra app/frontend site if you want Netlify Dev to pull hosted site environment variables; local workspace root `.env` values also work.

The local scan-capable setup uses two env files:

Expand Down
9 changes: 8 additions & 1 deletion netlify.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
[build]
publish="frontend/dist/spa/"
environment = { NODE_VERSION = "20.20.0", YARN_VERSION = "1.22.18"}
environment = { NODE_VERSION = "24.21.0", YARN_VERSION = "1.22.22"}
command = "yarn build-frontend"
[build.processing]
skip_processing = true

[functions]
directory = "netlify/functions"

[dev]
# Keep Quasar's in-memory assets ahead of the SPA fallback rewrite.
framework = "#custom"
7 changes: 4 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
"husky": "^4.3.0",
"lerna": "^3.22.1",
"lint-staged": "^10.5.1",
"netlify-cli": "27.6.0",
"prettier": "^2.1.2",
"rimraf": "^3.0.2",
"typescript": "^4.0.3"
Expand All @@ -39,15 +40,15 @@
"coverage": "lerna run coverage",
"test": "lerna run test",
"dev": "cd umbra-js && yarn build && cd ../frontend && yarn dev",
"dev:netlify": "netlify dev --command \"volta run --node 20.20.0 --yarn 1.22.18 yarn dev\" --target-port 8080 --port 8888"
"dev:netlify": "netlify dev --filter @umbra/frontend --command \"volta run --node 24.21.0 --yarn 1.22.22 yarn dev\" --target-port 8080 --port 8888"
},
"husky": {
"hooks": {
"pre-commit": "lerna run precommit"
}
},
"volta": {
"node": "20.20.0",
"yarn": "1.22.18"
"node": "24.21.0",
"yarn": "1.22.22"
}
}
Loading
Loading