Macintosh version of TSC

[iMacker2020]

Hi, I just finished porting 'The Secret Chronicles of Dr. M' to Mac OS X. Here is the link: http://www.mediafire.com/file/ai6jvq7xmmjf8ey/The_Secret_Chroncles_beta_1.zip/file

I would like to see this program available on the game's download page. Please let me know if there is anything else I need to do.

Thank you.

[xet7]

@iMacker2020

Where is your TSC source code, with changes you made to get Wekan building for Mac? URL at GitHub?

Where is your build script and instructions how you did build TSC for Mac? URL at GitHub?

You did only provide binary package.

[iMacker2020]

Where is your TSC source code, with changes you made to get Wekan building for Mac? URL at GitHub?

• I could compress it and attach it to this issue. Did you prefer a clone of the tsc repo with my patches applied to it?

Where is your build script and instructions how you did build TSC for Mac? URL at GitHub?

• Please let me know how you would like to receive this info.

Thank you.

[xet7]

@iMacker2020

It would be best if you could fork TSC repo and create a pull request.

If you are not familiar with that, then it's also OK to add all those files in .zip file attachment to this issue.

[Quintus]

Am Montag, dem 05. Oktober 2020 schrieb iMacker2020:

Hi, I just finished porting 'The Secret Chronicles of Dr. M' to Mac OS X. Here is the link: ttp://www.mediafire.com/file/ai6jvq7xmmjf8ey/The_Secret_Chroncles_beta_1.zip/file

First, thank you for your work. Be sure that is valuable to us. Please note, however, that we cannot accept contributions which are provided only in binary form as xet7 has outlined. You need to provide the source code so that we can include it into our code base. We need to review code before we can make it available to everyone; reasons for this include technical ones (e.g., code quality), security ones (we do not want to distribute malicious programmes on our website), and legal ones (TSC is licensed under the GPLv3, and this means need to provide the source code for any binaries we provide, just like you need to, btw.).

I would like to see this program available on the game's download page. Please let me know if there is anything else I need to do.

You can follow xet7's suggestions with regard to the fork button and Pull Request process. Alternatively, if you're unfamiliar with GitHub's interface and would rather like to provide a patch in diff format directly, you can do so as well. Just include the patch into this ticket or e-mail it to our mailing list[1]. Please do not just give us a full code dump of the entire changed TSC code base and have us figure out what you changed. This creates extra work for us and will make it more unlikely to get your changes included. -quintus [1]: See https://lists.secretchronicles.org/postorius/lists/tsc-devel.lists.secretchronicles.org/ -- you will receive an e-mail with instructions for posting after subscription.

…

-- Dipl.-Jur. M. Gülker | https://mg.guelker.eu | PGP: Siehe Webseite Passau, Deutschland | kontakt@guelker.eu | O<

[iMacker2020]

Sorry for the delay. Here is one patch I have made. I will post the rest when I finish them.
resource_manager.zip

[iMacker2020]

Patch for generic.cpp:
generic.zip

[iMacker2020]

Rename the Rect function to mRect() patch:
rename-Rect.zip

[iMacker2020]

Ambiguous symbol fix:
namespace.zip

[Quintus]

I apologise for the delay. Thank you for your provided patches. The contributions look mostly good for me, but some changes are required in order to get them merged. You replace Tinyclipboard with CEUGI::Clipboard, which is probably a good idea. I was not aware CEGUI contains a clipboard class; in fact, I had been looking forward to use SFML's newly added clipboard support, but if CEGUI supports clipboard access as well, that's just as fine. Once we decide to remove CEGUI (if ever), we'll have to change this, but don't have that bother you for now. However, your changes in the clipboard system break the clipboard support on Linux. Trying to copy/paste on a Linux system with your changes applied pastes garbage into CEGUI's edit boxes. Please verify a) that it works correctly on MacOS and if so, b) try to find out why it does not work on Linux. I suspect it won't work properly on MacOS either, but we'll see. Following are some minor things which can quickly be resolved. I give my comments directly related to the patch lines affected:

…

-- tsc/src/core/filesystem/resource_manager.cpp -- + game_folder_location += "/Resources/data"; + debug_print("game folder path = %s\n", game_folder_location.c_str()); Please don't print that information to the console here, as it is already printed by the cResource_Manager() constructor after init_directories() has finished. + preference_location += "/Library/Preferences/TSC"; + fs::path preferences_path(preference_location); + debug_print("Preferences folder path = %s\n", preference_location.c_str()); The same applies here.

-- tsc/src/gui/generic.cpp -- #include "../gui/generic.hpp" +#include <SFML/Audio.hpp> TSC has a policy of not using any external includes in most source code files. All external includes, in the correct order, belong into the file core/global_basic.hpp, which already includes SFML/Audio.hpp. Is there a specific reason why you need this `#include' statement here? As you removed Tinyclipboard's use completely, you should also remove the corresponding `#include' from global_basic.hpp and its Git submodule entry. - if (tiny_clipwrite(sel_text.c_str()) < 0) { - perror("Failed to write to clipboard"); - return 0; - } - else { - return 1; - } + CEGUI::Clipboard cb; + cb.setNativeProvider(cb.getNativeProvider()); + cb.setText(sel_text); If I read the docs correctly, it is sufficient to call setNativeProvider() once per programme. Please move it over to the game initialisation function for CEGUI, which is cVideo::Init_CEGUI() in video/video.cpp. That function is called once on TSC startup. Or do I read the docs wrong and it's necessary to call this function multiple times? - char* cliptext = tiny_clipread(NULL); + CEGUI::Clipboard cb; + cb.setNativeProvider(cb.getNativeProvider()); Likewise here. If a single global call suffices, remove it from here.

-- tsc/src/scripting/objects/sprites/mrb_sprite.cpp -- -static mrb_value Rect(mrb_state* p_state, mrb_value self) +static mrb_value mRect(mrb_state* p_state, mrb_value self) { cSprite* p_sprite = Get_Data_Ptr<cSprite>(p_state, self); @@ -751,7 +751,7 @@ void TSC::Scripting::Init_Sprite(mrb_state* p_state) mrb_define_method(p_state, p_rcSprite, "start_y=", Set_Start_Y, MRB_ARGS_REQ(1)); mrb_define_method(p_state, p_rcSprite, "pos", Pos, MRB_ARGS_NONE()); mrb_define_method(p_state, p_rcSprite, "start_pos", Start_Pos, MRB_ARGS_NONE()); - mrb_define_method(p_state, p_rcSprite, "rect", Rect, MRB_ARGS_NONE()); + mrb_define_method(p_state, p_rcSprite, "rect", mRect, MRB_ARGS_NONE()); The patch description gives the reasoning, but from the code alone it's not clear why `mRect' has this name. Please add an explanatory comment to the code itself. You can merge most of your patches into one. Please just keep the clipboard replacement patch separate as it affects more than just the MacOS compatibility. -quintus

-- Dipl.-Jur. M. Gülker | https://mg.guelker.eu | For security: Passau, Germany | kontakt@guelker.eu | () Avoid HTML e-mail European Union | PGP: see homepage | /\ http://asciiribbon.org

[xet7]

Here is combined patch, that is:

• with some whitespace fixes applied by me
• without clipboard changes and extra SFML include
• with changes from @Quintus applied

I did create patch with git diff > mac-combined.patch but I'm not sure is it a correct way to create a patch.

mac-combined.zip

@iMacker2020 Can you provide info how you installed dependencies and compiled TSC? Although, I will also try to figure it out myself.

[xet7]

It seems that in that precompiled Mac version of TSC provided, Mac did ask for permission for console app like TSC to capture clipboard data. So I presume clipboard code works. I'll try to do that clipboard code with ifdefs.

[xet7]

Here is updated patch that has:

• all of general patch added
• apple ifdefs and non-apple ifndefs added
• extra whitespace removed by xet7

mac-combined.zip

[xet7]

@iMacker2020

I tried to figure out how to install all dependencies, but it seems I just got endless amount of build errors. I have no idea at all how to build this Mac version of TSC.

Can you provide step by step instructions about how to build TSC for Mac?

[Quintus]

Am Freitag, dem 13. November 2020 schrieb Lauri Ojansivu:

I did create patch with `git diff > mac-combined.patch` but I'm not sure is it a correct way to create a patch.

I will look at your patches later on. For now, please give the `-u' option to diff(1) when you create patches directly with diff(1). This will make diff(1) use the patch format known from Git. -quinuts

…

-- Dipl.-Jur. M. Gülker | https://mg.guelker.eu | For security: Passau, Germany | kontakt@guelker.eu | () Avoid HTML e-mail European Union | PGP: see homepage | /\ http://asciiribbon.org

[iMacker2020]

I am working on the instructions still. It is almost done.

…

On Nov 13, 2020, at 8:36 PM, Lauri Ojansivu ***@***.***> wrote: @iMacker2020 I tried to figure out how to install all dependencies, but it seems I just got endless amount of build errors. I have no idea at all how to build this Mac version of TSC. Can you provide step by step instructions about how to build TSC for Mac? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.