Skip to content

Fit the draft and Live Review layout to phone screens - #1008

Merged
Senryoku merged 3 commits into
Senryoku:masterfrom
MNoya:mobile-draft-layout
Oct 29, 2026
Merged

Senryoku merged 3 commits into
Senryoku:masterfrom
MNoya:mobile-draft-layout

Conversation

@MNoya

@MNoya MNoya commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

On a phone, the spectator Live Review and the player's own pack used most of the screen poorly: a single column of cards with the right half empty, and a header split over five rows. This only changes styles below 600px, so the desktop layout is untouched.

  • Booster cards fit two per row at phone width, for both players and spectators. The zoom slider still scales them
  • The Live Review header fits in two rows: the Pack and Pick selectors share a row with the zoom slider, and the picked card name goes below them. A long player name is cut with an ellipsis instead of wrapping
  • Player chips use a bit less padding so the player list takes less height

The Live Review cards were squeezed into half the width because the zoom slider is floated right and the card container, being a flex box, sat beside the float. Making the header a wrapping flex row removes the float's effect.

Booster card width and margin now come from --booster-card-base-width and --booster-card-margin variables that default to 200px and 0.75em, so the pick animation and the pack's min-height follow the smaller phone cards.

Spectator Live Review at 390px

Before After
live-review-mobile-before live-review-mobile-after

Player pack at 390px

Before After
player-booster-mobile-before player-booster-mobile-after

- Booster cards fit two per row below 600px for players and spectators, and the zoom slider still scales them
- The Live Review header fits in two rows with the selectors and zoom slider sharing one
- Player chips take a little less height
@MNoya
MNoya marked this pull request as ready for review October 29, 2026 00:57
Remove hacky `float:right`
Switch to flex-direction: column in portrait mode
@Senryoku

Senryoku commented Oct 29, 2026 •

Copy link
Copy Markdown
Owner

The float: right was a mistake, we should get rid of it.
Sorry if I got a bit carried away this the changes, the normal booster controls switch to a column layout in portrait mode, I figured we could use the same approach here.
image
Otherwise I'm in favor of using a better default card width for smaller screens. Thanks!

@Senryoku
Senryoku merged commit efba2ea into Senryoku:master Oct 29, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants