Repository navigation
Conversation
The plugin declared sylius/core, sylius/core-bundle and sylius/taxation as ^1.0, but it binds to things that do not exist across all of 1.x: - ProductVariantPricesCalculatorInterface::calculateOriginal(), which arrived in 1.11 together with catalog promotions - the sylius.calculator.product_variant_price service id - the concrete Sylius\Bundle\CoreBundle\Twig\PriceExtension and the sylius.twig.extension.price service id CI only ever installs ~1.12.19, so 1.12 is the floor that is actually verified. Declaring it means an incompatible install fails during composer require rather than with a container or class error at runtime. Claude-Session: https://claude.ai/code/session_01P9NzuVPQGvaVR97HZFq98a
This was referenced Aug 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sylius/core,sylius/core-bundleandsylius/taxationwere all declared as^1.0, which claims support for the entire 1.x line. The plugin does not work on most of it — it binds to:ProductVariantPricesCalculatorInterface::calculateOriginal(), which arrived in 1.11 alongside catalog promotions (the interface itself replacedProductVariantPriceCalculatorInterfacein that release)sylius.calculator.product_variant_priceservice idSylius\Bundle\CoreBundle\Twig\PriceExtensionclass and thesylius.twig.extension.priceservice idSo the technical floor is 1.11. I went with 1.12 because that is the floor CI actually verifies — every job installs
~1.12.19— and declaring support for a version that is never tested is how you end up with bug reports you cannot reproduce.The practical effect is that an incompatible install now fails during
composer requirewith a readable message, instead of blowing up later with a container or class-not-found error.If you would rather genuinely support 1.11, I can send
^1.11plus a CI matrix entry for it instead — happy either way, it just needs a job backing it.Addresses the first architecture item in #5.
https://claude.ai/code/session_01P9NzuVPQGvaVR97HZFq98a