Remove hidden commands from JSON output exceptions - #8685
Merged
gonzaloriestra merged 1 commit intoSep 29, 2026
Merged
Conversation
github-actions
Bot
added
the
no-changelog
gonzaloriestra
marked this pull request as ready for review
September 28, 2026 15:21
dmerand
approved these changes
Sep 28, 2026
isaacroldan
approved these changes
Sep 29, 2026
gonzaloriestra
deleted the
gonzalo/remove-hidden-json-command-exceptions
branch
September 29, 2026 09:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Hidden commands should not need individual exceptions to the typed JSON output requirement.
WHAT is this pull request doing?
Skip commands with
static hidden = truein the lint rule and remove 18 hidden commands from the exception list. Add coverage to keep enforcing JSON output for visible commands and commands with an instancehiddenproperty.Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add