[WWSTCERT-13550] Sonoff - Add the pressure display function to SNZB-02M - #3194
Open
laity-w-sudo wants to merge 5 commits into
Open
[WWSTCERT-13550] Sonoff - Add the pressure display function to SNZB-02M#3194laity-w-sudo wants to merge 5 commits into
laity-w-sudo wants to merge 5 commits into
Conversation
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Profile category check: ✅ Passed - all profiles have a category defined. |
|
Invitation URL: |
Test Results 1 files 12 suites 0s ⏱️ Results for commit 1ca26b1. ♻️ This comment has been updated with latest results. |
|
zigbee-humidity-sensor_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against 1ca26b1 |
The SNZB-02M sub-driver was added but never registered, so the pressure display feature was dead code on the device. Register it via sub_drivers.lua, drop the unrelated SNZB-02LD/WD handler and utils (not in this driver, and referencing a nonexistent sub-driver), and add unit tests for pressure conversion and refresh. Co-Authored-By: Claude <noreply@anthropic.com>
laity-w-sudo
force-pushed
the
main
branch
2 times, most recently
from
August 25, 2026 11:23
ae161d5 to
b5e3665
Compare
KKlimczukS
reviewed
Aug 31, 2026
| @@ -0,0 +1,12 @@ | |||
| -- Copyright 2025 SmartThings, Inc. | |||
Contributor
There was a problem hiding this comment.
Suggested change
| -- Copyright 2025 SmartThings, Inc. | |
| -- Copyright 2026 SmartThings, Inc. |
Comment on lines
+1
to
+5
| --[[ | ||
| Description: SNZB-02M pressure/humidity/temperature sensor driver | ||
| Version: 1.0 | ||
| Author: GitHub Copilot | ||
| --]] |
Contributor
There was a problem hiding this comment.
Suggested change
| --[[ | |
| Description: SNZB-02M pressure/humidity/temperature sensor driver | |
| Version: 1.0 | |
| Author: GitHub Copilot | |
| --]] | |
| -- Copyright 2026 SmartThings, Inc. | |
| -- Licensed under the Apache License, Version 2.0 |
Comment on lines
+16
to
+18
| if raw_value > 2000 then | ||
| return raw_value / 1000.0 | ||
| end |
Contributor
There was a problem hiding this comment.
Please, could You add short explanation (in a comment) above this "if" statement regarding the edge case that forces this division ?
Comment on lines
+13
to
+14
| if CHANGED_DRIVERS: | ||
| DRIVERS = [driver for driver in DRIVERS if driver.name in CHANGED_DRIVERS] |
Contributor
There was a problem hiding this comment.
This change is not directly related to Your device.
KKlimczukS
changed the title
cjswedes
requested changes
Aug 31, 2026
Contributor
There was a problem hiding this comment.
Remove the changes to this file.
KKlimczukS
requested changes
Sep 1, 2026
| - id: refresh | ||
| version: 1 | ||
| categories: | ||
| - name: MultiFunctionalSensor |
Contributor
There was a problem hiding this comment.
Suggested change
| - name: MultiFunctionalSensor | |
| - name: HumiditySensor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check all that apply
Type of Change
Checklist
Description of Change
Adding the air pressure function to the SNZB-02M equipment
Summary of Completed Tests