Repository navigation
fix(kanidm): enable PKCE using intended mechanism - #1488
Merged
Merged
Conversation
Contributor
Author
|
Added tests inspired by some from another provider (Vipps) and confirmed they are passing locally. Please let me know if you need anything else. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A previous change (#1421) enabled PKCE for Kanidm by turning it on in the
getBaseUrl()function.This can cause authentication to fail if
usesPKCE()is called beforegetBaseUrl(), which is the case when using Kanidm with Lychee, resulting in a 500 error during the auth flow, and this error in Kanidm logs:AbstractProvider.php is meant to populate
code_verifierhere but doesn't, due tousesPKCE()returning false.This change adds the explicit function override for
usesPKCE(), which will properly indicate to socialite that PKCE is enabled.