feat: add OpenID Connect provider under a new Generic category - #87
Merged
Merged
Conversation
OpenID Connect implements a protocol rather than wrapping one service, so it doesn't fit alongside the platform providers. Adds a Generic category above the rest for that class of provider.
Providers#1475 merged the provider as src/OpenIDConnect, and the split published it as SocialiteProviders/OpenIDConnect. The openid-connect name only resolves via a GitHub rename redirect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lists the new OpenID Connect provider, merged in SocialiteProviders/Providers#1475 and split to SocialiteProviders/OpenIDConnect.
Maintainers: @adrum, @atymic.
New
GenericcategoryOpenID Connect implements a protocol rather than wrapping a single service, so it doesn't sit naturally next to Auth0, Okta or Keycloak in
Social / Platform— it's the thing those are built on. This adds aGenericsection, pinned above the other categories.Two knock-on effects, both intended:
Genericbecomes a validcategory:value in the Providers repo, sincesync-website.phpreads the section names out of this file.Genericis for.Why this needs a manual PR
#1475 carried the
new-providerlabel, sosync-website.phpshould have listed the provider automatically. It didn't, becausesrc/OpenIDConnect/README.mdhas nocategory:frontmatter — the sync rejects providers without one. Worth adding there so the automation isn't skipped next time.Notes
OpenIDConnect, matching the split repo.openid-connectalso resolves, but only through a GitHub rename redirect — both names point at the same repo, canonicallyOpenIDConnect.providers.jsparses clean: 10 categories, 277 providers. The fetch URL the build uses (.../OpenIDConnect/master/README.md) returns 200.