fix: green π Check β repoint moved fleet script paths + wire lockstep:emit-mirror-globs#1437
Open
John-David Dalton (jdalton) wants to merge 1 commit into
Open
fix: green π Check β repoint moved fleet script paths + wire lockstep:emit-mirror-globs#1437John-David Dalton (jdalton) wants to merge 1 commit into
John-David Dalton (jdalton) wants to merge 1 commit into
Conversation
β¦lobs The scripts/repo migration moved check.mts and update.mts into scripts/fleet/, but packages/cli/package.json still pointed its "check" and "update" scripts at the old ../../scripts/*.mts paths, failing check-script-paths-resolve. The lockstep-emit-mirror-globs.mts script cascaded in (and its sibling lockstep:emit-schema is wired), but the root package.json never got the matching lockstep:emit-mirror-globs alias, so the updating-lockstep skill docs cited a pnpm script that did not resolve, failing check-pnpm-run-citations-resolve. - packages/cli/package.json: check -> ../../scripts/fleet/check.mts - packages/cli/package.json: update -> ../../scripts/fleet/update.mts - package.json: add lockstep:emit-mirror-globs pointing at the existing scripts/fleet/lockstep-emit-mirror-globs.mts shim
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
main's
π Check(pnpm run check --all) is red, blocking every PR. Two independent fleet scripts/repo-migration cascade breakages:check-script-paths-resolveβpackages/cli/package.jsonstill pointedcheckandupdateat../../scripts/check.mts/../../scripts/update.mts. The scripts/repo migration moved both intoscripts/fleet/, so those paths no longer resolve.check-pnpm-run-citations-resolveβ the cascadedupdating-lockstepskill docs citepnpm run lockstep:emit-mirror-globs, but the rootpackage.jsonnever got the matching alias. The backing script (scripts/fleet/lockstep-emit-mirror-globs.mts) and its sibling alias (lockstep:emit-schema) are both present β only the wiring was missing.Fix
packages/cli/package.json:checkβ../../scripts/fleet/check.mtspackages/cli/package.json:updateβ../../scripts/fleet/update.mtspackage.json: addlockstep:emit-mirror-globsβnode scripts/fleet/lockstep-emit-mirror-globs.mts(points at the existing shim; mirrors thelockstep:emit-schemaentry byte-for-byte)Why this is a repo-local fix (not a wheelhouse change)
package.jsonentries here β noscripts/repo/sync-scaffolding/manifest.mtssynthesizer exists in this repo, so editingpackage.jsondirectly is the source of truth.lockstep:emit-mirror-globsscript file already exists and documents this exact invocation; socket-cli was simply missing the alias (a cascade gap), so adding it is wiring an existing script, not inventing one. The skill doc citation is correct and needs no edit.Verification (local, Node 24)
Also re-ran the sibling path-hygiene checks (all green):
paths-are-canonical,doc-references-resolve,release-publish-scripts-are-conventionally-named,lockstep-mirror-markers-are-declared,root-scripts-are-segregated,entry-scripts-are-fail-soft.Do not merge β a maintainer merges via
--adminonce a ruleset bypass is in place.Note
Low Risk
Only
package.jsonscript path and alias wiring; no runtime, auth, or business logic changes.Overview
Restores green
pnpm run check --allby fixing stalepackage.jsonwiring after fleet scripts moved underscripts/fleet/.In
packages/cli/package.json, thecheckandupdatescripts now invoke../../scripts/fleet/check.mtsand../../scripts/fleet/update.mtsinstead of the oldscripts/paths, socheck-script-paths-resolvepasses again.At the repo root,
lockstep:emit-mirror-globsis added as apnpmalias to the existingscripts/fleet/lockstep-emit-mirror-globs.mtsshim (same pattern aslockstep:emit-schema), so skill docs that citepnpm run lockstep:emit-mirror-globsresolve undercheck-pnpm-run-citations-resolve.Reviewed by Cursor Bugbot for commit 7478fe1. Configure here.