Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
assets/controllers.jsonautoimportstom-select.default.css. It is merged into theapp.adminandapp.shopbuilds and loaded after the Sylius admin styles, so.ts-dropdown { background: #fff }overrides the dark mode styles introduced in Sylius/Sylius#18981: autocomplete options are rendered in a light color on a white background.Both
AdminBundleandShopBundlealready disable this file and ship their own Tom Select styles (tom-select.bootstrap5.css). This PR aligns the app-levelcontrollers.jsonwith them.Before
Admin, dark mode, product edit page, "Attributes" tab:
After
Same page after rebuilding the assets (
yarn build):