Repository navigation
fix: use ns-nginx-cache slug and prevent unrelated plugin updates - #23
Closed
brianvarskonst wants to merge 1 commit into
Closed
brianvarskonst wants to merge 1 commit into
brianvarskonst wants to merge 1 commit into
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced by #24 after renaming the source branch to
feat/change-plugin-slug. The source commit is unchanged.The old
nginx-cacheslug can make WordPress offer an update from the unrelated WordPress.org plugin. Usens-nginx-cache/ns-nginx-cache.php, display NS Nginx Cache, and declare the GitHub repository as the plugin'sUpdate URIso WordPress.org excludes it from update responses while active or inactive. This uses WordPress's documented third-party update protection.Align Composer's install name and kernel entry, release archive names/folders, PHPCS input, compiled settings-link hook, stylesheet URLs, and version lookups with the new entry. The Composer package remains
sympress/nginx-cache; existing settings, queues, tables, cron hooks, REST routes, translation domain, and CLI commands keep their identifiers. Updates continue through Composer or release archives.Existing installations: follow
docs/migration.mdto deactivate the old SymPress installation, switch the directory/entry, reactivate with the previous site/network scope, and refresh cached update notices. Keep old files outside the plugins directory; using Delete can invoke the existing delete-on-uninstall setting.Validation:
composer validate --strictandcomposer qa: pass; 102 unit tests / 510 assertions.nginx-cache1.0.8 update; guarded old and new slugs received no update.4f92a2c9ea2db7271d6c49af101a4c63b6de65f4.ns-nginx-cache/root, matchingns-nginx-cache.php, correct source SHA and Composer metadata, 2,468 verified checksums, 41 production dependencies and no installed development packages.