Repository navigation
[TASK] Guard against silently losing a test case - #268
Merged
Merged
Conversation
Sync for EXT:solr — "[TASK] Guard against silently losing a test case". Records the 46 test methods of this extension and runs the check in CI. The script itself stays in EXT:solr and is called out of the installed package, so the record format is identical across the EXT:solr family and there is one implementation to maintain. Ported-From: TYPO3-Solr/ext-solr#TODO Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
When TYPO3-Solr/ext-solr carries a branch of the same name, `tests:env` now points the EXT:solr version for CI at it, so that a change spanning both repositories can be verified before either side is merged. Only upstream is consulted, because a branch out of a fork would run in CI with our secrets. The version is written as `dev-<branch> as <the version pinned so far>`, and that alias keeps other packages' constraints on EXT:solr satisfiable, so neither require-dev nor `tests:setup` needs changing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to TYPO3-Solr/ext-solr#4754 and TYPO3-Solr/ext-solrfal#367, and the first
set of the dead-code EPIC.
[TASK] Guard against silently losing a test caseBuild/Test/known-tests.txtrecords every test method of both suites with thenumber of cases it contributes — 46 methods / 70 cases — and CI fails when a
recorded method disappears or contributes fewer cases than before. The check itself
lives in EXT:solr and is called out of the installed package, so the record format
stays identical across the EXT:solr family and there is one implementation to
maintain.
The record is a floor, not an inventory: additions never fail it, so a feature
PR needs no update. Only a removal or a rename does, which is exactly the change
that has to be justified in review.
[TASK] Test against the matching EXT:solr branch when upstream has oneThe guard needs the script from EXT:solr, which is not on EXT:solr
mainyet — sothis PR would have been red until #4754 merged, which is precisely the pressure we
do not want on EXT:solr
main.tests:envtherefore points the EXT:solr version for CI at a branch of the samename whenever TYPO3-Solr/ext-solr carries one. Here that is
epic/remove-dead-code/PR-1, installed asdev-epic/remove-dead-code/PR-1 as 14.0.x-dev; the alias keeps constraints otherpackages put on EXT:solr satisfiable, so neither
require-devnortests:setupchanges. Once #4754 is merged and the branch is gone, the lookup finds nothing and
the pinned
14.0.x-devapplies again — no follow-up needed here.Only the upstream repository is consulted: a branch out of a fork must never be
installed into CI, where it would run with our secrets.
The same mechanism is already green in ext-solrfal#367, where it pins EXT:solr and
EXT:tika at once.
Please rebase-merge, do not squash
The commit split is the deliverable for every PR in this EPIC.