Skip to content

Add props to player alias subscriptions - #1091

Merged
tudddorrr merged 1 commit into
developfrom
plaeyer-subscription-props
Oct 12, 2026
Merged

tudddorrr merged 1 commit into
developfrom
plaeyer-subscription-props

Conversation

@tudddorrr

Copy link
Copy Markdown
Collaborator

Subscription props

  • Introduce a PlayerAliasSubscriptionProp entity so player relationships can store arbitrary key/value metadata.
  • Add the migration, snapshot update and entity registration needed to persist props.

API support

  • Let clients pass props when creating a relationship, so metadata is set at subscription time.
  • Add a PATCH endpoint to add, overwrite or delete props on an existing subscription, where a null value removes the prop.
  • Limit prop updates to the subscription owner so a subscribed player can't modify the other side's props.

Validation & caching

  • Apply the existing length and profanity rules to subscription props, rejecting the whole request and returning the offending props when any are invalid.
  • Invalidate cached relationship responses whenever props change so subscribers and subscriptions always reflect the latest values.

@codecov

codecov Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.75%. Comparing base (a9406b4) to head (8a20ec1).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1091      +/-   ##
===========================================
+ Coverage    98.73%   98.75%   +0.02%     
===========================================
  Files          530      532       +2     
  Lines         8153     8206      +53     
  Branches      1059     1067       +8     
===========================================
+ Hits          8050     8104      +54     
  Misses          36       36              
+ Partials        67       66       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tudddorrr
tudddorrr force-pushed the plaeyer-subscription-props branch from 35617aa to 07a5a88 Compare October 12, 2026 06:09
@tudddorrr
tudddorrr force-pushed the plaeyer-subscription-props branch from 07a5a88 to 8a20ec1 Compare October 12, 2026 06:14
@tudddorrr
tudddorrr merged commit edd2388 into develop Oct 12, 2026
9 checks passed
@tudddorrr
tudddorrr deleted the plaeyer-subscription-props branch October 12, 2026 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant