Fix library include path for remover/updater - #790
Open
kinnajowa wants to merge 1 commit into
Open
Conversation
Owner
|
Reproduced on Debian. Will look into it. Thanks! |
TheAssassin
approved these changes
Aug 22, 2026
TheAssassin
left a comment
TheAssassin
left a comment
Owner
There was a problem hiding this comment.
Looks good. Let's build some packages, and I'll try on my broken system ASAP!
Owner
|
Thinking about it, maybe this should be solved with linuxdeploy. But I like your approach, too. |
Owner
|
This doesn't work: I'm not sure how this can happen, but it also happens in the old build if you set |
Owner
|
Fun fact: when called like Maybe the real solution is to just rename the tool to a sensible name and install it. Or integrate it into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR represents the minimum set of changes necessary to properly include shared libraries required by the remove/update tools into the private libdir. This bug prevented the removal of AppImages when using the default remove action specified in the .desktop file, as it silently fails due to the missing libraries (tested on Ubuntu 26.04).
No actual changes to code, just to CMakeList.txt files.