Repository navigation
Prefer supports_descriptor_buffer over feature check - #157
Open
DiscoStarslayer wants to merge 1 commit into
Open
DiscoStarslayer wants to merge 1 commit into
DiscoStarslayer wants to merge 1 commit into
Conversation
Contributor
|
I have had the same issue. I thought it was related to Android support for descriptor buffers, so I have been disabling it on Android altogether (https://github.com/gopher64/parallel-rdp/blob/dd012f5651b16b311417cd9e664ae54c056ae6d2/patches/android.patch), but I think this is the root cause. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A user of mine was experiencing random crashes with a Intel Arc B580 on Parallel-GS: DiscoStarslayer/pcsx2-reliquary#42
Spent a bunch of time going back and forth with them and narrowed down the fix to this change.
Essentially, the GPU reports that it supports descriptor buffers, however, Granite marks the descriptor buffers on this GPU as disabled because the Intel Arc B580 GPU does not support
combinedImageSamplerDescriptorSingleArray.memory_allocator.cppandshader.cppcheck the GPU's descriptor buffer support instead of checking if Granite has decided to use the GPU's descriptor buffer or not.Because the buffers were not setup on ARC, this was causing random heap corruption and was tricky to nail down.