Repository navigation
vulkan: Fix self-deadlock in legacy implicit queue sync - #158
Merged
Merged
Conversation
Owner
|
Right, the legacy paths don't get tested much. Fix seems correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On devices without timeline semaphores,
emit_implicit_sync_to_queues()runs with the devicelock held (called from
submit_queue()/submit_empty_inner()), but callsrequest_legacy_semaphore()->request_semaphore(), which takesLOCK()again on the samenon-recursive
std::mutexand hangs forever.Hit on NVIDIA Tegra X1 (Shield TV, Android 11, Vulkan 1.1.178, driver 495.00) while running the
PyroWave decoder. Backtrace of the hung thread:
The fix allocates the binary semaphore directly, as the other
_nolockpaths do. With it, thedecoder runs correctly on that device (output matches a desktop GPU decode at ~57 dB PSNR).
(Context: that driver also lacks VK_KHR_synchronization2; I'm opening a separate PyroWave issue
about Vulkan 1.1 / sync2 support. This fix is independent of that.)