Clean up failed note uploads

[ZeyadAbbas]

Description

A failed PDF upload can leave behind a note database record even though no corresponding PDF exists in storage.

Steps To Reproduce

Begin a note upload. Make the storage request fail. Inspect the created note record.

Additional Context

No response

Version

a local development branch

Environment

Browser: Chrome
Operating System: Windows

[ZeyadAbbas]

Hey @SXT230118 I would like to point out that there has been a change made to this issue. Since PR #219 the way PDFs are handled changed slightly. here is the edit in the issue description.

Before: A failed PDF upload can leave a note record with an empty file URL.
After: A failed PDF upload can leave behind a note database record even though no corresponding PDF exists in storage.

Subtle, but important to know the difference,