Fix/pdf picker label (associate PDF file input with visible label (#202)) - #226
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
an accident whoops |
|
any chance you could give more info on how you tested and how you used AI? |
I just tested this by running it locally and i checked that the label properly targets the file input when clicked, i also checked the inspect element to check if htmlfor matched the input id I used AI to check the React accessibility syntax for linking the htmlfor to the input id and checking the overall branch setup |
|
@KavinRaj117 Could you please resolve the conflicts and commit? These conflicts are related to the refactor that happened after this PR. Apologies for the inconvenience. |
Hey @ZeyadAbbas, I've resolved the merge conflicts with develop, and all the build and lint checks are passing now Since there was quite a bit changed in the recent refactor, I was a little confused during the merge process and wanted to make sure everything stayed clean. Could you give it a quick recheck when you have a moment to ensure everything looks good on your end? |
|
Hey @KavinRaj117! Yep, everything looks great. Good job getting all right! |
Associates the PDF file input with its visible label tag using
htmlForandid, and addsaria-labelfor screen reader accessibility.Closes #202