Skip to content

Fix/pdf picker label (associate PDF file input with visible label (#202)) - #226

Merged
ZeyadAbbas merged 6 commits into
developfrom
fix/pdf-picker-label
Sep 22, 2026
Merged

ZeyadAbbas merged 6 commits into
developfrom
fix/pdf-picker-label

Conversation

@KavinRaj117

Copy link
Copy Markdown
Contributor

Associates the PDF file input with its visible label tag using htmlFor and id, and adds aria-label for screen reader accessibility.

Closes #202

@KavinRaj117
KavinRaj117 requested review from a team as code owners September 9, 2026 23:42
@vercel

vercel Bot commented Sep 9, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
utd-notebook Ready Ready Preview Sep 21, 2026 2:09pm UTC

Request Review

@justinschwerdtfeger

Copy link
Copy Markdown
Contributor

an accident whoops

@justinschwerdtfeger

Copy link
Copy Markdown
Contributor

any chance you could give more info on how you tested and how you used AI?

@KavinRaj117

Copy link
Copy Markdown
Contributor Author

any chance you could give more info on how you tested and how you used AI?

I just tested this by running it locally and i checked that the label properly targets the file input when clicked, i also checked the inspect element to check if htmlfor matched the input id I used AI to check the React accessibility syntax for linking the htmlfor to the input id and checking the overall branch setup

@ZeyadAbbas

Copy link
Copy Markdown
Contributor

@KavinRaj117 Could you please resolve the conflicts and commit? These conflicts are related to the refactor that happened after this PR. Apologies for the inconvenience.

@KavinRaj117

Copy link
Copy Markdown
Contributor Author

@KavinRaj117 Could you please resolve the conflicts and commit? These conflicts are related to the refactor that happened after this PR. Apologies for the inconvenience.

Hey @ZeyadAbbas, I've resolved the merge conflicts with develop, and all the build and lint checks are passing now

Since there was quite a bit changed in the recent refactor, I was a little confused during the merge process and wanted to make sure everything stayed clean. Could you give it a quick recheck when you have a moment to ensure everything looks good on your end?

@ZeyadAbbas

Copy link
Copy Markdown
Contributor

Hey @KavinRaj117! Yep, everything looks great. Good job getting all right!

@ZeyadAbbas
ZeyadAbbas merged commit d264df8 into develop Sep 22, 2026
3 checks passed
@ZeyadAbbas
ZeyadAbbas deleted the fix/pdf-picker-label branch September 22, 2026 00:36

This branch was successfully deployed

1 active deployment
Preview — 79a095ab Deployed Sep 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Label the PDF file picker

3 participants