Repository navigation
Restrict EEPROM device identity to catalog and fix read size - #13
Merged
Merged
Conversation
The EEPROM manager dialog let the user write arbitrary device identity into EEPROM: device_type listed the whole DeviceType enum (incl. UNKNOWN) and device_version / hardware_revision were free 0-255 spin boxes, so combinations absent from xDOS_devices.yaml could be written. Replace them with cascading combo boxes driven by KNOWN_DEVICES: device type lists only catalogued families, version is filtered by type, and HW revision by type+version (None shown as "—", mapped to stored byte 0). Loading EEPROM whose combination is not in the catalog now shows a warning and falls back to valid entries so it can be overwritten, instead of being silently accepted. Also fix "Blob too short" on load: the dialog read a hardcoded 101 bytes while the struct is TOTAL_SIZE (113), so unpack_record always failed. Use TOTAL_SIZE for the real read, the log message, and the demo 0xFF fallback block.
roman-dvorak
approved these changes
Jun 21, 2026
roman-dvorak
left a comment
roman-dvorak
left a comment
Member
There was a problem hiding this comment.
Předpokládám, že funkčnost řešení byla otestována
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The EEPROM manager dialog let the user write arbitrary device identity into EEPROM: device_type listed the whole DeviceType enum (incl. UNKNOWN) and device_version / hardware_revision were free 0-255 spin boxes, so combinations absent from xDOS_devices.yaml could be written.
Replace them with cascading combo boxes driven by KNOWN_DEVICES: device type lists only catalogued families, version is filtered by type, and HW revision by type+version (None shown as "—", mapped to stored byte 0). Loading EEPROM whose combination is not in the catalog now shows a warning and falls back to valid entries so it can be overwritten, instead of being silently accepted.
Also fix "Blob too short" on load: the dialog read a hardcoded 101 bytes while the struct is TOTAL_SIZE (113), so unpack_record always failed. Use TOTAL_SIZE for the real read, the log message, and the demo 0xFF fallback block.