Conversation
…ema_version temp file CHAIN_VERSION 4.1.0 -> 4.1.1 so validators running the #174 fix are visible on chain (running_version); hardfork_version masks the patch component, so the HF15 hardfork version stays 4.1.0 and activation is unchanged. Open the schema_version temp file with O_TRUNC instead of O_EXCL: a crash before rename plus PID reuse in a restarted container made every start fail with EEXIST.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the #174 review by @chiliec.
CHAIN_VERSION4.1.0 → 4.1.1. Nodes running the HF15: AgentKeys correctness fixes (port of #173) #174 fix now reportrunning_version4.1.1, so upgrades can be tracked on chain before HF15 (2026-10-05 00:00 UTC).hardfork_versionmasks the patch component, so the HF15 hardfork version stays 4.1.0 anddatabase_hardfork.cpp's<= CHAIN_VERSIONcheck still holds.schema_versiontemp file opened withO_TRUNCinstead ofO_EXCL: a crash between open and rename, followed by PID reuse in a restarted container, made every start fail withEEXIST.Docs line for the key_history marker row and the snapshot-export warning will follow separately.
🤖 Generated with Claude Code