Turn Expr into a proper range instead of a view - #593
Merged
Conversation
Previously, the Expr implementation used range-v3's view facade to implement range semantics on Expr objects. However, views are different things from containers which had some more or less subtle consequences. See also https://stackoverflow.com/a/31462435 This commit replaces the view facade with virtual begin/end implementations returning ExprIterator objects. Hence, Expr is now a fully fledged container that is usable as a random-access range.
Collaborator
Author
|
Okay, I'll have to change the impl to make some protected helper functions like |
Krzmbrzl
marked this pull request as draft
August 19, 2026 18:23
This avoids the issue of not being able to shadow begin/end in subclasses as shadowing is not allowed for virtual functions.
Krzmbrzl
marked this pull request as ready for review
August 20, 2026 08:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the Expr implementation used range-v3's view facade to
implement range semantics on Expr objects. However, views are different
things from containers which had some more or less subtle consequences.
See also https://stackoverflow.com/a/31462435
This PR replaces the view facade with virtual begin/end
implementations returning ExprIterator objects. Hence, Expr is now a
fully fledged container that is usable as a random-access range.