Skip to content

chore: deploy PrimeV2 implementation and MarketFacet on bscmainnet - #720

Merged
fred-venus merged 5 commits into
developfrom
feat/VPD-1982-bscmainnet-deployments
Oct 22, 2026
Merged

fred-venus merged 5 commits into
developfrom
feat/VPD-1982-bscmainnet-deployments

Conversation

@Debugger022

Copy link
Copy Markdown
Contributor

Summary

Changes

bscmainnet deployments

  • PrimeV2_Impl: new implementation at 0xb61137934C9D52cF3ebe9BCe92586DcA048b5F88
  • MarketFacet: new facet at 0x935905A58E91a406eead60cd9AAbC7a64EDAe264 (replaces 0x21f8E1471b153f49BE1d645A008E4a57434eEd23)
  • solcInputs/a7231c01f111b9244bf31e27ecc3e8ea.json: compiler input for the above

Not included

  • PrimeLens is not yet redeployed on bscmainnet.
  • bscmainnet.json and bscmainnet_addresses.json are regenerated by CI.
  • The PrimeV2 proxy upgrade, the diamondCut replacing MarketFacet, and the ACM permission for enterMarketForAccount(address,address) go in a separate VIP.

Test plan

  • Compiled develop and compared deployedBytecode (immutables masked) against on-chain code at both addresses: exact match.
  • Confirmed the PrimeV2 proxy on bscmainnet still points to the old implementation and the Diamond returns the zero address for enterMarketForAccount, so nothing is live until the VIP executes.
  • Same bytecode is already live on bsctestnet (0x0191Bb3CD28A96691F5EC5066ad42A0373ae11C6, 0x52f4c550a310340284e07B4A8A2722c20C71D39B), deployed in [VPD-1982]: support PrimeV2 markets with underlyings above 18 decimals #710.

@Debugger022 Debugger022 self-assigned this Oct 22, 2026
@greptile-apps

greptile-apps Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] This deployment-record update appears safe to merge.

Summary

Records the mainnet deployments of PrimeV2_Impl and MarketFacet, with their shared compiler input.

  • BSC mainnet deployment records now list the new PrimeV2 and MarketFacet contracts.

Acknowledged scope from Debugger022:

  • PrimeLens redeployment is deferred.
  • CI regenerates bscmainnet.json and bscmainnet_addresses.json.
  • A separate VIP will upgrade the proxy, update the Diamond, and grant the ACM permission.

Reviews (1) · Last reviewed commit: "chore: deploy PrimeV2 implementation and..." · Reviewed by Greptile

@github-actions

Copy link
Copy Markdown

Code Coverage

Package Line Rate Branch Rate Health
contracts 100% 100% ✔
contracts.Admin 88% 41% ✔
contracts.BStock 100% 97% ✔
contracts.Comptroller 100% 90% ✔
contracts.Comptroller.Diamond 95% 66% ✔
contracts.Comptroller.Diamond.facets 88% 74% ✔
contracts.Comptroller.Diamond.interfaces 100% 100% ✔
contracts.Comptroller.Types 100% 100% ✔
contracts.Comptroller.legacy 100% 100% ✔
contracts.Comptroller.legacy.Diamond 0% 0% ❌
contracts.Comptroller.legacy.Diamond.facets 0% 0% ❌
contracts.Comptroller.legacy.Diamond.interfaces 100% 100% ✔
contracts.DelegateBorrowers 100% 89% ✔
contracts.FlashLoan.interfaces 100% 100% ✔
contracts.Governance 68% 45% ➖
contracts.InterestRateModels 74% 59% ➖
contracts.Lens 44% 47% ❌
contracts.Liquidator 83% 60% ✔
contracts.Oracle 100% 100% ✔
contracts.PegStability 88% 84% ✔
contracts.Swap 88% 58% ✔
contracts.Swap.interfaces 100% 100% ✔
contracts.Swap.lib 81% 55% ✔
contracts.Tokens 100% 100% ✔
contracts.Tokens.Prime 97% 82% ✔
contracts.Tokens.Prime.Interfaces 100% 100% ✔
contracts.Tokens.Prime.libs 90% 77% ✔
contracts.Tokens.VAI 82% 52% ✔
contracts.Tokens.VRT 20% 9% ❌
contracts.Tokens.VTokens 71% 53% ➖
contracts.Tokens.VTokens.legacy 0% 0% ❌
contracts.Tokens.VTokens.legacy.Utils 0% 0% ❌
contracts.Tokens.XVS 19% 8% ❌
contracts.Tokens.test 100% 100% ✔
contracts.Utils 52% 31% ➖
contracts.VAIVault 50% 45% ➖
contracts.VRTVault 49% 36% ❌
contracts.XVSVault 63% 50% ➖
contracts.external 100% 100% ✔
contracts.lib 89% 71% ✔
Summary 62% (4554 / 7351) 49% (1785 / 3676) ➖

@fred-venus fred-venus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fred-venus
fred-venus merged commit ce09168 into develop Oct 22, 2026
7 checks passed
@vancegpt-bot vancegpt-bot mentioned this pull request Oct 22, 2026
3 of 4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants