Conversation
(s-left -1 "") signals args-out-of-range, so pressing backspace in deadgrep-incremental before typing anything (or after deleting the whole term) errored out of the incremental search. Make backspace a no-op when the term is already empty. Also add a docstring to deadgrep-incremental. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MwUBSSJnCtCeoqJEA3xH48
Wilfred
force-pushed
the
claude/fix-incremental-backspace
branch
from
August 18, 2026 21:31
6d3f792 to
8a14ce3
Compare
|
coverage: 59.79% (-0.07%) from 59.86% — claude/fix-incremental-backspace into master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pressing backspace in
deadgrep-incrementalwhen the search term is empty (before typing anything, or after deleting the whole term) signalledargs-out-of-range, because(s-left -1 "")calls(substring "" 0 -1). Backspace is now a no-op when the term is already empty; deleting the last character uses a plainsubstring.Also adds the missing docstring to
deadgrep-incremental.🤖 Generated with Claude Code
https://claude.ai/code/session_01MwUBSSJnCtCeoqJEA3xH48