Repository navigation
Accept canonical account and state ledger_entry locators - #22
Closed
GautamBytes wants to merge 98 commits into
Closed
GautamBytes wants to merge 98 commits into
GautamBytes wants to merge 98 commits into
Conversation
Header-only consteval RPC spec DSL shared by Clio and rippled. Includes Conan header-library packaging, CMake install/export rules, and standalone unit tests exercising the rippled (xrpl::) backend.
The DSL compiles against xrpl protocol headers (via detail/XrplNs.hpp) in both backends. Rather than pull libxrpl into the test build, mock the small protocol surface the tests touch in tests/stubs/xrpl_mock.hpp, exposed behind the eight <xrpl/...> shim headers XrplNs.hpp includes. tests/stubs is placed first on the include path so those resolve to the mock. Also disable boost cobalt in the conan recipe (boost 1.91 package_info fails on cobalt_io_ssl otherwise); only Boost::json is needed.
Admission spec
Admission spec: Add a default implementation of Resolver.
godexsoft
requested changes
Sep 28, 2026
| field("accounts", required, kRippleStateAccountsValidator), | ||
| field("currency", required, currency)), | ||
| rippleStateConv), | ||
| AliasedLocator{ |
Collaborator
There was a problem hiding this comment.
I don't like how we have to duplicate the body of the field and how it's AliasedLocator{...} instead of the DSL style (e.g. alias(...) or field({"name1", "name2"}, ...)). The idea is good though and seems needed so let's make it more of a DSL and less duplication 👍
Collaborator
|
@GautamBytes this needs to rebase on develop and re-open. Sorry for inconvenience |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accept
account/statealongsideaccount_root/ripple_state, including hex state indexes. Reject conflicting alias names.Part of XRPLF/clio#3215. Clio needs a release containing this fix and its matching handler update.