Repository navigation
Cherry pick mcdm m1.0 xrt smi - #10108
Merged
Merged
Conversation
aktondak
requested review from
AShivangi,
chvamshi-xilinx,
rbramand-xilinx and
stsoe
as code owners
October 9, 2026 16:03
* Remove validate tests from PFs (Xilinx#10040) Signed-off-by: Akshay Tondak <aktondak@amd.com> * [XRT-SMI] Cleanup logic into specific files and prune VF specific options (Xilinx#10047) Signed-off-by: Akshay Tondak <aktondak@amd.com> * update platform report (Xilinx#10052) Signed-off-by: Akshay Tondak <aktondak@amd.com> * CR-1272937: xrt::kernel::group_id() throw on missing memory connectivity (Xilinx#10028) When a kernel argument has no memory bank connectivity, group_id() returned 65535 (no_memidx encoded as 0xFFFF). Passing that value to xrt::bo() caused a cryptic std::out_of_range crash instead of an actionable error. Validate the argument index and memory group assignment in group_id() and throw xrt_core::error(EINVAL) with a descriptive message. connectivity and no_memidx are public so group_id() can use them. Signed-off-by: Srikanth Vuppala <120363307+svup-xilinx@users.noreply.github.com> Signed-off-by: Akshay Tondak <aktondak@amd.com> * CR-1272937: throw from group_id() only for buffer arguments (Xilinx#10059) group_id() must still throw when a global/constant argument has no memory connectivity so xrt::bo is not given bank 0xffff. Scalar, stream, and local arguments are queried by field applications and must keep the legacy encoded invalid group. Signed-off-by: Srikanth Vuppala <120363307+svup-xilinx@users.noreply.github.com> Signed-off-by: Akshay Tondak <aktondak@amd.com> * AIESW-41600 Remove skipped validate tests for npu3 (Xilinx#10062) Signed-off-by: Ryan Chane <rchane@xilinx.com> Signed-off-by: Akshay Tondak <aktondak@amd.com> * update list of commands for vf (Xilinx#10075) Signed-off-by: Akshay Tondak <aktondak@amd.com> * xrt-smi: gate validate hidden options, align --pmode help, report each --loop iteration (Xilinx#10076) Require --advanced to parse validate hidden options (matching examine), and use the same --pmode mode list as configure for Ryzen/NPU3. Run the validate --loop iterations from the validate subcommand instead of inside TestRunner::startTest, so each iteration's result is printed and recorded in the JSON output instead of only the last one. A warning in a later iteration no longer masks an earlier failure. Signed-off-by: Akshay Tondak <aktondak@amd.com> * Support displaying soft realtime in aie-partitions report (Xilinx#10085) Signed-off-by: Ryan Chane <rchane@xilinx.com> Signed-off-by: Akshay Tondak <aktondak@amd.com> * [XRT-SMI] Add warning for enabled categories after disable (Xilinx#10081) Signed-off-by: Akshay Tondak <aktondak@amd.com> * Use create_dtrace_handle_elf API for creating dtrace handle (Xilinx#10084) Signed-off-by: Sri Latha Ayyannagari <SriLatha.Ayyannagari@amd.com> Signed-off-by: Akshay Tondak <aktondak@amd.com> * xrt-smi: support platform device identification and aie2ps validate archive (Xilinx#10093) Signed-off-by: Wendy Liang <wendy.liang@amd.com> Signed-off-by: Akshay Tondak <aktondak@amd.com>
aktondak
force-pushed
the
cherry-mcdm-m1.0-xrt-smi
branch
from
October 9, 2026 17:38
549be0f to
6a1a447
Compare
stsoe
reviewed
Oct 9, 2026
stsoe
left a comment
stsoe
left a comment
Collaborator
There was a problem hiding this comment.
Is there a ticket that requests these specific cherry-picks?
Collaborator
Author
There is no ticket. Should I file one ? |
stsoe
approved these changes
Oct 9, 2026
Collaborator
No, but I was looking for some paper trail on how these cherry picks were picked. |
maxzhen
approved these changes
Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a cherry pick commit of following 11 commits in mcdm_m1.0 branch :
2ec8af2 #10040 Remove validate tests from PFs
dffe5a6 #10047 Cleanup logic into specific files and prune VF specific options
d8ececf #10052 update platform report
4eee345 #10062 Remove skipped validate tests for npu3
745e2d6 #10075 update list of commands for vf
ecad6cf #10076 gate validate hidden options, align --pmode help, report each --loop iteration
2bfd112 #10081 Add warning for enabled categories after disable
e53d8bf #10085 Support displaying soft realtime in aie-partitions report
1932bdf #10093 support platform device identification and aie2ps validate archive
fb86838 #10084 Use create_dtrace_handle_elf API for creating dtrace handle
202bdf2 #10059 throw from group_id() only for buffer arguments
#10028 (d1989f0), “CR-1272937: xrt::kernel::group_id() throw on missing memory connectivity.”